Skip to content

Image preprocessor refactor#71

Merged
AyleenSohaib merged 2 commits intodevelopmentfrom
dev_image_preprocessor_refactor
Aug 18, 2023
Merged

Image preprocessor refactor#71
AyleenSohaib merged 2 commits intodevelopmentfrom
dev_image_preprocessor_refactor

Conversation

@Sajtospoga01
Copy link
Copy Markdown
Contributor

Changes external interface of the imagepreprocessor package to use callable classes instead of the hard to use list dict function definition. Internal interface remains the same

…in a more natural manner. Changes external interface (due to the new callable structure, unchanged internal interface)
@Sajtospoga01 Sajtospoga01 added enhancement New feature or request refactoring labels Aug 18, 2023
@Sajtospoga01 Sajtospoga01 self-assigned this Aug 18, 2023
@Sajtospoga01 Sajtospoga01 temporarily deployed to development August 18, 2023 10:03 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2023

Codecov Report

Merging #71 (a27b892) into development (32aef90) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development      #71      +/-   ##
===============================================
+ Coverage        73.85%   73.96%   +0.10%     
===============================================
  Files                8        8              
  Lines              723      726       +3     
===============================================
+ Hits               534      537       +3     
  Misses             189      189              
Files Changed Coverage Δ
...ts/segmentation_utils_tests.py/flow_reader_test.py 85.41% <ø> (ø)
utilities/segmentation_utils/flowreader.py 58.24% <ø> (ø)
...entation_utils_tests.py/image_preprocessor_test.py 80.00% <100.00%> (-0.96%) ⬇️
...sts/segmentation_utils_tests.py/test_flowreader.py 100.00% <100.00%> (ø)
utilities/segmentation_utils/ImagePreprocessor.py 79.72% <100.00%> (+1.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AyleenSohaib AyleenSohaib merged commit 99b88c2 into development Aug 18, 2023
@AyleenSohaib AyleenSohaib deleted the dev_image_preprocessor_refactor branch August 18, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants