Hearse support

[Ranbato]

Any chance of porting the Hearse support from the iOS version?

The Hearse code is available at https://github.com/dirkz/iNetHack/tree/master/Classes . It is in Obj-C, but really the process shouldn't be too complicated.

Thanks,
Ranbato

[gurrhack]

I have hearse support on my wish list. Can't promise it will be done in the near future

[Ranbato]

Android Nethack is 'just' an ARM build of Nethack with a Java overlay for
settings and display but I wanted to confirm with you before enabling as I
know iNethack added some fields to distinguish itself from other versions
in Hearse.

Here is the data on the bones files produced by Gurr's Android Nethack:
./bones-info.pl -va bonD0.3 bonD0.3: 5781 bytes read as: little endian
incarnation: 50594561 (3.4.3.1) feature_set: 1973318 (REINCARNATION SINKS
KOPS TOURIST STEED GOLDOBJ TEXTCOLOR INSURANCE ELBERETH EXP_ON_BOTL)
entity_count: 555417981 (33 artifacts, 432 objects, 381 monsters)
struct_sizes: 2759951812 (164 flag, 64 obj, 97 monst, 452 you)

Let me know if there is anything I need to do before starting to test it.

Thanks,
Mark

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[Ranbato]

I think I have designed a way to achieve a different version info without
breaking compatibility by flipping an unused bit in feature_set in
makedefs.c:482 and then masking it out with IGNORED_FEATURES
(makdefs.c:419).

I haven't implemented it though so take a look at the bones file and see
what you think. If it will cause problems I'll make and test the change.

Sent the bones separately.

Thanks,
Mark

On Sat, Dec 13, 2014 at 5:49 PM, Alexis Manning alexismanning@gmail.com
wrote:

Well, If it is going to cause problems then we can leave it as it is, it
should already be unique but I tend towards the paranoid. Can't see the
Dev Team releasing a 3.4.3.1 (or, in fact, anything) in the forseeable
future.

Can you send me a bones file, as I try to upload it as the final part of
my testing?

Thanks

Alexis
On 13 Dec 2014 19:12, "Ranbato" ranbato@gmail.com wrote:

OK,
I'll have to decide what to add, do a build, etc. before I can provide
one.

Guess this update will have to go out with a backward compatibility
notice.

Thanks,
Mark

On Sat, Dec 13, 2014 at 10:44 AM, Alexis Manning <alexismanning@gmail.com

wrote:

Hi Mark

No problems; for my paranoia I like to make sure it is very different
from other NH versions so there is no risk of a nominally valid file being
offered and causing a problem. If you wouldn't mind adding a dummy object
or monster or two (with zero probability of creation, obviously), that
would be great.

Just about to head out, but if you could email me a bones file then I
can add it to the database this weekend and you can test away,

Alexis

On 13 December 2014 at 15:40, Ranbato ranbato@gmail.com wrote:

Android Nethack is 'just' an ARM build of Nethack with a Java overlay
for settings and display but I wanted to confirm with you before enabling
as I know iNethack added some fields to distinguish itself from other
versions in Hearse.

Here is the data on the bones files produced by Gurr's Android Nethack:
./bones-info.pl -va bonD0.3 bonD0.3: 5781 bytes read as: little endian
incarnation: 50594561 (3.4.3.1) feature_set: 1973318 (REINCARNATION SINKS
KOPS TOURIST STEED GOLDOBJ TEXTCOLOR INSURANCE ELBERETH EXP_ON_BOTL)
entity_count: 555417981 (33 artifacts, 432 objects, 381 monsters)
struct_sizes: 2759951812 (164 flag, 64 obj, 97 monst, 452 you)

Let me know if there is anything I need to do before starting to test
it.

Thanks,
Mark

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and
   make such financial profit, political mileage, or good joke as it lends
   itself to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your
   company.
4. This overrides any disclaimer or statement of confidentiality
   that may be included on your message.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and
   make such financial profit, political mileage, or good joke as it lends
   itself to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[gurrhack]

The nethack source is modified for the Android version. I'm not sure if it affects bones file compatibility though, but I would use a unique version tag on Hearse just to be safe

[Ranbato]

I have modified the version in Nethack in (i think) a backward compatible
way, but I can't get my apk to install so I can test it. I have allowed
unknown sources and set up a keystore locally to sign the apk.

Do I need to create a certificate from my keystore and install it on my
device?

I'm off next week from work so I expect I can get everything done fairly
quickly if I can get the @#%&! thing to install.

Thanks,
Mark

On Sun, Dec 14, 2014 at 1:57 AM, gurrhack notifications@github.com wrote:

The nethack source is modified for the Android version. I'm not sure if it
affects bones file compatibility though, but I would use a unique version
tag on Hearse just to be safe

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[gurrhack]

That shouldn't be necesary, but if you already have nethack installed you need to uninstall it first.

http://developer.android.com/tools/publishing/app-signing.html

[Ranbato]

Yea, tried that too.
Looks like I'll have to try some samples.

On Dec 21, 2014, 7:37 AM, at 7:37 AM, gurrhack notifications@github.com wrote:

That shouldn't be necesary, but if you already have nethack installed
you need to uninstall it first.

http://developer.android.com/tools/publishing/app-signing.html

---

Reply to this email directly or view it on GitHub:
#6 (comment)

[Ranbato]

Switched computers and now it is working. Net Version is working correctly
and new properties are showing up in UI.

Working on network transmission and converting from little-endian to
big-endian for validating bones files version info.

I'd like to move UpdateAssets.findDataPath() to Nethack object so I can
access it from Hearse to locate the Bones files. Any concerns or
suggestions of a better way to do it?

Thanks,
Mark

On Sun, Dec 21, 2014 at 8:21 AM, Ranbato ranbato@gmail.com wrote:

Yea, tried that too.
Looks like I'll have to try some samples.
On Dec 21, 2014, at 7:37 AM, gurrhack notifications@github.com wrote:

That shouldn't be necesary, but if you already have nethack installed you
need to uninstall it first.

http://developer.android.com/tools/publishing/app-signing.html

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[gurrhack]

Don't use that function! It's only called the first time to determine a "good" location to store the files. And it should be rewritten actually, because it doesn't work as it was intended when I first made it.

Anyways, when the game has started the data path is stored in the preferences

Preferences prefs = mNetHack.getPreferences(Activity.MODE_PRIVATE);
String path = prefs.getString("datadir");

[Ranbato]

Hah, I totally missed that there are 2 separate sets of preferences.

I was using the other one exclusively and it was returning nothing for the
datadir.

On Mon, Dec 22, 2014 at 9:26 AM, gurrhack notifications@github.com wrote:

Don't use that function! It's only called the first time to determine a
"good" location to store the files. And it should be rewritten actually,
because it doesn't work as it was intended when I first made it.

Anyways, when the game has started the data path is stored in the
preferences

Preferences prefs = mNetHack.getPreferences(Activity.MODE_PRIVATE);String path = prefs.getString("datadir");

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[Ranbato]

Almost everything is working. A few interface things need polishing.

1. I think I want to add a dialog to prompt them for email when they
   turn on Hearse.
2. Not sure how I should provide messages back from Hearse to UI.
3. Right now calling Hearse in onStop, but I'm not sure that is the best
   place to call it.

Any suggestions for 2 & 3?

Thanks,
Mark

On Mon, Dec 22, 2014 at 9:49 AM, Ranbato ranbato@gmail.com wrote:

Hah, I totally missed that there are 2 separate sets of preferences.

I was using the other one exclusively and it was returning nothing for the
datadir.

On Mon, Dec 22, 2014 at 9:26 AM, gurrhack notifications@github.com
wrote:

Don't use that function! It's only called the first time to determine a
"good" location to store the files. And it should be rewritten actually,
because it doesn't work as it was intended when I first made it.

Anyways, when the game has started the data path is stored in the
preferences

Preferences prefs = mNetHack.getPreferences(Activity.MODE_PRIVATE);String path = prefs.getString("datadir");

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and
   make such financial profit, political mileage, or good joke as it lends
   itself to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[tek909]

Hey guys. Been watching the progress on this. If you need any testing let me know. I have not coding know how and pretty much focus on tiles but I have a note 4 and play alot :)

[Ranbato]

Sounds good. I have to go back to work this week so it will take a little
longer before it is ready for public testing.

On Fri, Dec 26, 2014 at 8:15 PM, tek909 notifications@github.com wrote:

Hey guys. Been watching the progress on this. If you need any testing let
me know. I have not coding know how and pretty much focus on tiles but I
have a note 4 and play alot :)

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

Disclaimer:
By sending an email to ANY of my email addresses you are agreeing that:

1. I am by definition, "the intended recipient"
2. All information in the email is mine to do with as I see fit and make
   such financial profit, political mileage, or good joke as it lends itself
   to. In particular, I may post it to the internet.
3. I will take the contents as representing the views of your company.
4. This overrides any disclaimer or statement of confidentiality that
   may be included on your message.

[gurrhack]

It shouldn't matter when it's started, as long as it's a separate process that doesn't block NetHack. You don't want to wait for Hearse to do its job every time you try to exit NetHack. Ideally it should be implemented as a stand-alone application that can be started manually at any time, just like the Unix Hearse client. (Also, if it's separated like that it can be used with UnNetHack as well)

As for messages, I'm not sure. Since Hearse is a service-like process that runs in the background and can take a while to finish, maybe it should use Android's notification system for that instead of being integrated with NetHack's UI?