Fix get_many raised TypeError when using with Django-Cachalot #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/pymemcache
add close method
bump version
add ignore_cluster_errors params
bump version
Initial Update
When pymemcache server does not found at
`client = self._get_client(key)`.
current implementation returns `{'key': False}`.
But this return value would raise following exception.
```
File "/tmp/app/lib/python3.6/site-packages/cachalot/monkey_patch.py", line 85, in inner
cache_key, table_cache_keys)
File "/tmp/app/lib/python3.6/site-packages/cachalot/monkey_patch.py", line 51, in _get_result_or_execute_query
timestamp, result = data.pop(cache_key)
TypeError: 'bool' object is not iterable
```
https://github.com/BertrandBordage/django-cachalot/blob/master/cachalot/monkey_patch.py#L39-L45
So, this patch ignore if server does not found, just return `{}` to
avoid raise TypeError.
Author
|
sorry miss |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry. I missed PR.