Updating to reflect changes in 1.7 #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 1.7 changed the PyLibMCCache definition to remove _local and move _client (previously referenced as _local.client) up a level.
Author
|
Tested in both 1.6.5 and 1.7 |
Owner
|
i little bit changed you pull request to avoid code duplication for creating client. |
Author
|
Cool, thanks! |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition for Django's PyLibMCCache changed, removing the _local field and moving _client (previously referenced as _local.client) up a level. The logic now forks to check if _local exists, and then uses