Corrected issues with sed reserved characters#2
Merged
Conversation
Author
|
Closes #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected issues with sed reserved characters
This was causing the
TARGET_SERVERto perform incorrect sed substitution. Fixed it by using a different separator,instead of the/. This means that paths can now be directly entered into theTARGET_SERVERvariable, as such:Added path filtering
On some instances, such as it is the case with Plex, proxying into a path is not enough, because the http files have the path hardcoded. Adding a filter block allows for those URLs to be rewritten in the response, allowing the assets to be loaded correctly. There might be some tweaks to make here, but the initial implementation seems to be working.
In order to use the functionality, a path must be used in
TARGET_SERVERand theFILTER_PATHvariable must be set to 1 (this is a safeguard, to ensure filtering is not done by default).A new
TARGET_SERVERURL-parsing block has been added tostart.shit can successfully dissect every part of the URL allowing for better future substitutions if needed. I am only using the path parsing part of it at the moment.Other changes
Removed the
HTTP_PATHvariable, as it can now be extracted from theTARGET_SERVERparsing block.