External gdb module #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pyfile that is specified in the module metadata wasn't allowed to be a folder. This is a problem to us, as the gdb module is not a single python file. These modifications allow people to add pyfile recursive dirs from non-Lib locations. Also modified deep_freeze.py to accept surrogates in text it receives. Not sure why it received surrogates though, something from pygments.
Changed the package check macro to check for config variable before using pkg-config. This allows us to disable unwanted modules in the future. This required a regeneration of the autoconf files. Because the autoconf files are relatively old at this point and were not created with the same autoconf version, a lot of changes have been made.
guyush1
requested changes
Jan 8, 2025
We use the external environment variable for getting the necessary libraries for GDB, so they have been removed from statically being included in the frozen modules file.
roddyrap
force-pushed
the
external-gdb-module
branch
from
e88c7f2 to
74ab746
Compare
guyush1
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.