Automate building using docker #1
Conversation
|
Hello Guysh. Here is my humble addition to you project. |
|
Notice that it currently only builds the native version for x86 |
|
Hello @RoiKlevansky :) Thank you for your contribution, much appreciated! Later on we might be able to make it so we regularly release new gdb updates automatically. |
RoiKlevansky
force-pushed
the
build-using-dockerfile
branch
from
4ee8258 to
1d31959
Compare
|
I made some great changes to this PR. Now there is a build.sh file, which is even generic and works out of docker. I hope you will find this to your liking. |
RoiKlevansky
changed the title
RoiKlevansky
changed the title
|
Thank you very much! I will go over this pr as soon as i am able to |
RoiKlevansky
force-pushed
the
build-using-dockerfile
branch
from
1d31959 to
2d46cc4
Compare
|
Well, it took me some time. But I rewrote the whole thing. Now, the build system is capable of downloading the packages only once, and keep them for later use. This cuts down on downloads, while also cutting down on disk space (all build targets share the downloads). |
Your work is much appreciated. I will go over the changes sooni-ish :) |
|
Tiny change, I forgot to strip the binaries after build. |
|
@RoiKlevansky I left some comments out in the pr. While it might seem like a lot of comments, most of them are small, and you shall decide what to do with them. gl hf :) EDIT: btw, after we finish this issue we publish a new release, since gdb-15.2 released a few days ago. |
src/build.sh
Outdated
| } | ||
|
|
||
| if [[ $# -ne 3 ]]; then | ||
| >&2 echo "Usage: $0 <target_arch> <build_dir> <gdb_patch>" |
There was a problem hiding this comment.
It is a bit weird that you still always re-apply the gdb patches.
maybe you should do it in the dependency downloader script (make it verbose if you decide to do it, so that the user knows he is getting a patches version!)
There was a problem hiding this comment.
I think that I have found an even better solution!
I've split the patching mechanism into a separate "patch_gdb.sh" script, which the Makefile runs. A stamp is used in order to guarantee that it is only executed once.
This is quite a bit more elegant (at least I think), and I sure do hope that you'd like it too.
|
Thank you for the time you put into this amazing project. You know, it's with people like you that we went to the moon! Anyway, I'll go over your issues as soon as I can. I want you to know that I already managed to write a GitHub Workflow pipeline for the project. It's even capable of automatically publishing releases! |
RoiKlevansky
force-pushed
the
build-using-dockerfile
branch
from
f837607 to
6d07d3a
Compare
|
I think that I'm kind of reaching the state where I'm ok with the design choices of this PR. It feels like no hacks are needed! |
|
I think that right now, the only thing about this PR that sends shivers down my spine is the Makefile. Still, I don't see any way of making it any simpler. At the end of the day, most Makefiles are weird, it's nothing new. |
|
Glad to see you're back! |
I am actually on vacation right now :) |
|
@RoiKlevansky any updates on this m8 :) ? |
RoiKlevansky
force-pushed
the
build-using-dockerfile
branch
from
6d07d3a to
4cde133
Compare
|
I fixed some of the issues and left comments on the ones I didn't fix. I sure do hope that it will get merged soon! |
guyush1
left a comment
guyush1
left a comment
There was a problem hiding this comment.
Thank you so much for your effort & time! much appreciated!
|
It's been a pleasure! Now, let's continue conquering our goals! |
2 participants
No description provided.