Skip to content

Conversation

@guyush1
Copy link
Owner

@guyush1 guyush1 commented Dec 27, 2024

No description provided.

@guyush1 guyush1 self-assigned this Dec 27, 2024
@guyush1
Copy link
Owner Author

guyush1 commented Dec 27, 2024

This pr closes #25

@guyush1
Copy link
Owner Author

guyush1 commented Dec 27, 2024

For some reason ci-cd is not running. @roddyrap any ideas why :) ?

@roddyrap
Copy link
Collaborator

Good question, I will check

@guyush1
Copy link
Owner Author

guyush1 commented Dec 27, 2024

I need to add the with-python build targets to the ci-cd (both release and regular pipelines)
edit: done!

@guyush1
Copy link
Owner Author

guyush1 commented Dec 27, 2024

Good question, I will check

@roddyrap
No need, i just remembered i needed to update the ci-cd anyways since we need to include both build and build-with-python options now. After i pushed the change, ci-cd was triggered. It was probably a bug the first time...

done using a 2d matrix involving the build type (regular or with python)
@guyush1 guyush1 force-pushed the allow-build-with-and-without-python branch from 2b2b993 to 6738ced Compare December 30, 2024 21:21
@guyush1 guyush1 merged commit f7e97ca into develop Dec 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants