Skip to content

fix wizard crash #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmerejkowsky wants to merge 2 commits into from
Closed

fix wizard crash #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e8d65
fix crash during wizard
dmerejkowsky May 3, 2017
896c7d9
Fix crash when creating github requests
dmerejkowsky May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions git_repo/services/ext/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def request_create(self, onto_user, onto_repo, from_branch, onto_branch, title=N
if not onto_project:
raise ResourceNotFoundError('Could not find project `{}/{}`!'.format(onto_user, onto_repo))

from_reposlug = self.guess_repo_slug(self.repository, self)
from_reposlug = self.guess_repo_slug(self.repository, self, resolve_targets=['{service}'])
if from_reposlug:
from_user, from_repo = from_reposlug.split('/')
if (onto_user, onto_repo) == (from_user, from_repo):
Expand Down Expand Up @@ -339,7 +339,7 @@ def request_fetch(self, user, repo, request, pull=False, force=False):
@classmethod
def get_auth_token(cls, login, password, prompt=None):
import platform
if self.fqdn != GITHUB_COM_FQDN:
if cls.fqdn != GITHUB_COM_FQDN:
gh = github3.GitHubEnterprise()
else:
gh = github3.GitHub()
Expand All @@ -359,4 +359,3 @@ def get_auth_token(cls, login, password, prompt=None):
@property
def user(self):
return self.gh.user().login