Update gitlab init to remove deprecation warnings #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python-gitlab [docs](http://python-gitlab.readthedocs.io/en/stable/api-usage.html#gitlab-gitlab-class) indicate that: * the private key should be specified in the gitlab.Gitlab constructor (`gitlab.Gitlab.set_token` is deprecated) * `gitlab.Gitlab.token_auth` is deprecated, should now be `gitlab.Gitlab.auth` This pull request deals with both of these issues.
Author
|
Oof, I just noticed this was discussed in issue 280, completely missed the SSL part. Probably best to disregard this. |
guyzmo
reviewed
Jul 6, 2017
|
|
||
| def __init__(self, *args, **kwarg): | ||
| self.gl = gitlab.Gitlab(self.url_ro) | ||
| self.gl = gitlab.Gitlab(self.url_ro, private_token=self._privatekey) |
Owner
There was a problem hiding this comment.
at this time the privatekey in self._privatekey is not known :-/
Owner
|
thank you a lot for having done a PR ♥, but I'll have to reject this PR cf #280 and my comment! ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python-gitlab docs indicate that:
gitlab.Gitlab.set_tokenis deprecated)gitlab.Gitlab.token_authis deprecated, should now begitlab.Gitlab.authThis pull request deals with both of these issues.
(BTW, the
set_urlcall on line 33 seems to be redundant since the URL is specified when creating thegitlab.Gitlabinstance, but I didn't have the time to test.)