Skip to content

Refine service client tests #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrahamCampbell merged 1 commit into from
May 25, 2026
Merged

Refine service client tests #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions tests/ServiceClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace GuzzleHttp\Tests\Command\Guzzle;
namespace GuzzleHttp\Tests\Command;

use GuzzleHttp\Client as HttpClient;
use GuzzleHttp\Command\Command;
Expand Down Expand Up @@ -103,23 +103,42 @@ function (
$this->assertSame(200, $result['status']);
}

public function testExecuteCommandViaMagicMethod(): void
public function testMagicMethodExecutesCommandSynchronously(): void
{
$client = $this->getServiceClient([
new Response(200, [], '{"foo":"bar"}'),
]);

$result = $client->doThatThingYouDo(['fizz' => 'buzz']);

$this->assertSame('bar', $result['foo']);
$this->assertSame('buzz', $result['_request']['fizz']);
$this->assertSame('doThatThingYouDo', $result['_request']['action']);
}

public function testMagicMethodExecutesCommandAsynchronously(): void
{
$client = $this->getServiceClient([
new Response(200, [], '{"foofoo":"barbar"}'),
]);

// Synchronous
$result1 = $client->doThatThingYouDo(['fizz' => 'buzz']);
$this->assertEquals('bar', $result1['foo']);
$this->assertEquals('buzz', $result1['_request']['fizz']);
$this->assertEquals('doThatThingYouDo', $result1['_request']['action']);
$result = $client->doThatThingOtherYouDoAsync(['fizz' => 'buzz'])->wait();

$this->assertSame('barbar', $result['foofoo']);
$this->assertSame('buzz', $result['_request']['fizz']);
$this->assertSame('doThatThingOtherYouDo', $result['_request']['action']);
}

public function testMagicMethodUsesEmptyArgumentsWhenNoneArePassed(): void
{
$client = $this->getServiceClient([
new Response(200, [], '{"ok":true}'),
]);

$result = $client->listWidgets();

// Asynchronous
$result2 = $client->doThatThingOtherYouDoAsync(['fizz' => 'buzz'])->wait();
$this->assertEquals('barbar', $result2['foofoo']);
$this->assertEquals('doThatThingOtherYouDo', $result2['_request']['action']);
$this->assertTrue($result['ok']);
$this->assertSame('listWidgets', $result['_request']['action']);
}

public function testCommandExceptionIsThrownWhenAnErrorOccurs(): void
Expand Down