Something wrong with version handeling Get-HPDockUpdateDetails

[Riinmo]

Hi Gary, Thanks for contributing with the Get-HPDockUpdateDetails function!
However i think with the new firmware of the Universal dock G2 there is something wrong with the version handeling.
it seems as if the newer version is not needed when there is a new version.

see the following output:

PS C:\WINDOWS\system32> Get-HPDockUpdateDetails

Name Value

---

SoftpaqNumber sp161512
UpdateRequired False
SoftpaqFirmware 1.1.24.0
Dock HP USB-C Universal Dock G2
InstalledFirmware 1.1.23.0

PS C:\swsetup\dockfirmware\sp161512> Get-HPDockUpdateDetails -UIExperience NonInteractive -Update -Transcript
Transcript started, output file is C:\swsetup\dockfirmware\sp161512-20250922.txt
23.09.07.03
Running script with CMSL = True
Executing a dock firmware update
Softpaq already downloaded to C:\swsetup\dockfirmware\sp161512.exe
Softpaq already Extracted to C:\swsetup\dockfirmware\sp161512
Extracted Softpaq Info file: C:\swsetup\dockfirmware\sp161512\HPFIConfig.xml
Softpaq for Device: HP USB-C/A Universal Dock G2
Softpaq Version: 1.1.24.0
Running HP Firmware Check... please, wait
Firmware is up to date
Installed Version: 1.1.23.0
Transcript stopped, output file is C:\swsetup\dockfirmware\sp161512-20250922.txt

is there something i have missed or could there be an other issue?

[Riinmo]

An update, i do see that there might be a change in names of the Universal dock G2. See the following registry:

[gwblok]

I have no way to reproduce this issue. I no longer work for HP and no longer have access to several of the docks, or any new docks coming out.

If you find a solution and would like to provide the code to resolve the issue, I'll be happy to update the script.

[morpheuz1911]

Can confirm this. It seems like it's altered behaviour in HPFirmwareInstaller.exe by HP.
It no longer outputs the error code as exit code, but simply outputs 0.

When HPFirmwareInstaller.exe is called, it tattoos the registry, as seen in @Riinmo post.
EDIT: I've merged both scripts together, so I apologize for that, hence the line mixups.
But the switch on line 650 is based off the exit code on HPFirmwareInstaller.exe(line 633), which always returns "0", when in fact the check returns 105 in the registry:

So one way would be to get the value after the test has been run is to get the registry value instead of the exit code.
However, HP seems to put in tattoos for each dock in there, so it could be wise to clear out the registry keys before
running the test, so there's always a single entry to check.

[morpheuz1911]

In https://github.com/gwblok/garytown/blob/master/hardware/HP/Docks/Function_Get-HPDockUpdateDetails.ps1

Altered line 595 from:
$HPFirmwareTest = Start-Process -FilePath "$OutFilePath\$SPNumber\$FirmwareInstallerName" -ArgumentList "-C" -PassThru -Wait -NoNewWindow

To:
Get-ChildItem -Path "HKLM:\SOFTWARE\HP\HP Firmware Installer" | Remove-Item -Recurse -Force -Confirm:$false $HPFirmwareTest = Start-Process -FilePath "$OutFilePath\$SPNumber\$FirmwareInstallerName" -ArgumentList "-C" -PassThru -Wait -NoNewWindow $HPFirmwareTestCode = Get-ChildItem -Path "HKLM:\SOFTWARE\HP\HP Firmware Installer\*" | Get-ItemProperty -Name ErrorCode | Select-Object -ExpandProperty ErrorCode

Line 612 from:
switch ( $HPFirmwareTest ) {

to
switch ( $HPFirmwareTestCode ) {

Line 673 from:
New-ItemProperty -Path $DockEssentialRegPath -Name 'ErrorCode' -Value $HPFirmwareTest.ExitCode -PropertyType dword -Force | Out-Null

to
New-ItemProperty -Path $DockEssentialRegPath -Name 'ErrorCode' -Value $HPFirmwareTestCode -PropertyType dword -Force | Out-Null

As well as others.
I made a pull request for you to check.
morpheuz1911@0187419

[gwblok]

@morpheuz1911, I've added your changes to the script, thank you!
However I can't test anymore, I don't have the docks.

If you and @Riinmo are able to test, that would be great!

[morpheuz1911]

I ran a test with my code additions yesterday successfully on my dock(G2). Will continue later today with the G5 (not Essential, yet at least. Need to locate one in our environment.).
Will report back results.

EDIT: USB-C G5 works as well.