feat: replace CompendiumBrowserView sheet with CompendiumSelectorSheet (#113)#154
Merged
Conversation
#113) Wire CompendiumSelectorSheet into EncounterBuilderView as the adversary selection sheet, replacing the tab-based CompendiumBrowserView modal. CompendiumSelectorSheet owns its own NavigationStack and dismisses itself on selection, so the onSelect callback is a direct pass-through to addAdversary. ContentStore is threaded through from ContentView and EncounterAndPartyRootView to support the sheet's import flow. CompendiumBrowserView is deleted; nothing in code referenced it after this change. Closes #113
- Delete BrowserTab.swift (only consumer was CompendiumBrowserView) - Remove setEnvironment(_:) from EncounterBuilderView (no sheet path calls it now) - Drop stale CompendiumBrowserView references from AdversaryListView and EnvironmentListView header comments Tracks environment browsing follow-up in #155.
…erView CompendiumBrowserView was deleted in this branch and modified on main. Keeping the deletion; the view is fully replaced by CompendiumSelectorSheet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompendiumBrowserViewmodal inEncounterBuilderViewwithCompendiumSelectorSheet, per the M3a redesign planContentStorethroughContentViewandEncounterAndPartyRootViewintoEncounterBuilderViewso the sheet's Import DHPack button worksCompendiumBrowserView.swift— nothing in code references it after this changeWhat changed
EncounterBuilderView— addedcontentStore: ContentStoreparameter; replaced theNavigationStack { CompendiumBrowserView(...) }sheet withCompendiumSelectorSheet. The selector sheet owns its ownNavigationStackand callsdismiss()on selection, soonSelectis a direct pass-through toaddAdversary.ContentView/EncounterAndPartyRootView— passcontentStoredown toEncounterBuilderViewat both call sites.CompendiumBrowserView.swift— deleted.Reviewer notes
BrowserTab.swiftis now dead code (its only consumer wasCompendiumBrowserView). Flagged for a separate follow-up.CompendiumSelectorSheetis adversary-only. Environment browsing from the editor will be addressed in a future issue.Closes #113