Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌍 Help me translating Sniffnet in your native language 🌍 #60

Open
GyulyVGC opened this issue Feb 7, 2023 · 33 comments
Open

🌍 Help me translating Sniffnet in your native language 🌍 #60

GyulyVGC opened this issue Feb 7, 2023 · 33 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed translation User interface translation

Comments

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2023

In v1.1 I introduced the possibility to select a language for the GUI.
If you are a native speaker of a language for which a translation isn't there yet (or a language that's not fully up to date), it'd be awesome if you could help me translating the application.

The translation is mostly appreciated if you think that the language is potentially spoken by a good amount of people using Sniffnet


➡️ All you have to do is to add the translations to these files:

Thanks in advance to everyone ❤️


Language Code Flag Updated to v1.1? Updated to v1.2? Updated to v1.3?
English EN 🇬🇧
German DE 🇩🇪 ✅ (#87) ✅ (#191) ✅ (#495)
Greek EL 🇬🇷 ✅ (#160)
Spanish ES 🇪🇦 ✅ (#70) ✅ (#203)
Persian* FA 🇮🇷 ✅ (#158) ✅ (#193)
Finnish FI 🇫🇮 ✅ (#310) ✅ (#310)
French FR 🇫🇷 ✅ (#64 - #67) ✅ (#279) ✅ (#494)
Italian IT 🇮🇹
Japanese JA 🇯🇵 ✅ (#343) ✅ (#343) ✅ (#504)
Korean KO 🇰🇷 ✅ (#128) ✅ (#205)
Polish PL 🇵🇱 ✅ (#78) ✅ (#244) ✅ (#498)
Portuguese PT 🇵🇹 ✅ (#134) ✅ (#398)
Romanian RO 🇷🇴 ✅ (#113) ✅ (#241) ✅ (#499)
Russian RU 🇷🇺 ✅ (#151) ✅ (#187) ✅ (#496)
Swedish SV 🇸🇪 ✅ (#213) ✅ (#213)
Turkish TR 🇹🇷 ✅ (#139) ✅ (#192)
Ukrainian UK 🇺🇦 ✅ (#94) ✅ (#216)
Uzbek UZ 🇺🇿 ✅ (#385) ✅ (#385) ✅ (#510)
Chinese ZH 🇨🇳 ✅ (#89 - #93) ✅ (#214)

*A Persian translation has been submitted and approved, but is not available in-app since RTL languages aren't supported yet by the GUI library in use.

@GyulyVGC GyulyVGC added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 7, 2023
@GyulyVGC GyulyVGC pinned this issue Feb 7, 2023
@acolombier
Copy link
Contributor

I have started adding french as part of the PR #64, however, as mentioned in there:

Worth to mention that although native speaker, it has been a few years I have written my own language in a formal way, so if there is any fellow french speakers that could help review it, that would be massively appreciated!

@Charpy
Copy link
Contributor

Charpy commented Feb 10, 2023

I have started adding french as part of the PR #64, however, as mentioned in there:

Worth to mention that although native speaker, it has been a few years I have written my own language in a formal way, so if there is any fellow french speakers that could help review it, that would be massively appreciated!

Hi ! as I'm a french native I did some review on the french translation. I'm not very used to Github features so I hope everything worked well with "branches, pull up, commit, merge"... I kept the reviewed file locally so feel free to contact me if needed.

@AmadeusGraves
Copy link
Contributor

Added Spanish. Cheers!

@Charpy
Copy link
Contributor

Charpy commented Feb 19, 2023

I've added polish translation at #78, but yoy already answered that PR 😅

Also a question regarding other translations - Since I don't speak these languages - is the space before " : " intended? @AmadeusGraves eg.

Adaptador de red : {adapter}\n\n\

I don't mean to offend anyone, but visually it seems very displeasing, at least it is considered in my native language.

Hello ! In french official typographic code, we need a space before and after the " : " caracter. It is even recommended to use a "non breaking space", with is a special space with stick to his two caracters so they aren't separeted by end of the line. See https://en.m.wikipedia.org/wiki/Non-breaking_space for more infos.

@keiveulbugs
Copy link

Started with Dutch

@GyulyVGC
Copy link
Owner Author

GyulyVGC commented Mar 2, 2023

Started with Dutch

Hey @keiveulbugs, I saw your translation is halfway but you don't have opened a PR yet.
Any news?

@captain-yossarian
Copy link

@GyulyVGC added Ukrainian translation

@vrmiguel
Copy link

@GyulyVGC I'll translate it to Brazilian Portuguese

@toastal
Copy link

toastal commented Apr 13, 2023

Don't use flags for languages. Flags represent nations; not the languages inside its borders. For accuracy's and politics's sake, just use the ISO language codes.

@GyulyVGC
Copy link
Owner Author

Don't use flags for languages. Flags represent nations; not the languages inside its borders. For accuracy's and politics's sake, just use the ISO language codes.

While I agree with you, I must admit that flags are able to more immediately visually represent a concept.
I mean, it wouldn't be so clear to include at the beginning of the README just the language codes, and so on.
I think that keeping both the codes and the flags is the best option for my use case.
However thanks for having pointed out!

@fuzunspm
Copy link
Contributor

added Turkish translation

@4r7if3x
Copy link
Contributor

4r7if3x commented Apr 19, 2023

I've added Persian translations alongside some improvements in the font and language support: #158

@4r7if3x
Copy link
Contributor

4r7if3x commented Apr 21, 2023

@GyulyVGC The correct Dutch language code is NL. Please modify it in the table above.

P.S. NE is the language code for Nepali

@GyulyVGC
Copy link
Owner Author

@GyulyVGC The correct Dutch language code is NL. Please modify it in the table above.

You're right! Thanks for the good catch!

@GyulyVGC
Copy link
Owner Author

Hey @acolombier @AmadeusGraves @Charpy @Kiruyuto @luca3s @cxw620 @captain-yossarian @ervinpopescu @DocRAID @fuzunspm @amarao @franciscoBSalgueiro @abousis @4r7if3x

I'm tagging you all because I've just published a new Sniffnet release which needs a little update to the translations.
It's about 25 new very short phrases, most of which are composed by just few words.

➡️ All you have to do is to add the translations to this file:

Thank you all very much in advance for the help ❤️

@amarao
Copy link
Contributor

amarao commented May 18, 2023

I want to point to a small problem with language ordering in each match. Re-scanning by eye whole list every time for 'own' language. Having them sorted in any (but persistent) order will help a lot.

@amarao
Copy link
Contributor

amarao commented May 18, 2023

What is '"Administrative entity' in the packet filtering? I honestly have no idea. It accepts only 2 and 0, and filter out only connection to DE (????)

Oh, I got it. It's autonomous system (AS), and I would never guess it by English name.

@GyulyVGC
Copy link
Owner Author

What is '"Administrative entity' in the packet filtering? I honestly have no idea. It accepts only 2 and 0, and filter out only connection to DE (????)

It's a more friendly way to refer to https://en.wikipedia.org/wiki/Autonomous_system_(Internet)

@amarao
Copy link
Contributor

amarao commented May 18, 2023

I know very well what 'AS' is, but this name is completely off compare to all software I used. Also, it does not doing filtration. I've tried to filter out out AS (7979) while having connections with servers.com, and I can't see any packets. Is it working?

@GyulyVGC
Copy link
Owner Author

You have to filter by AS name, not by AS number.
How would you suggest to call it?
I feel like "Autonomous System" is not familiar at all to not networking experts.

@amarao
Copy link
Contributor

amarao commented May 18, 2023

It's either sounds nothing (and it's hard to explain to layman), or a person knows well what it is. I suggest 'AS name' or "Autonomous System Name" as well-established name for this field.

For now I'll keep Russian translation of "имя автономной системы" (name of autonomous system) there, if you don't mind.

@amarao
Copy link
Contributor

amarao commented May 18, 2023

Also I can't find use of color_gradients_translation in the code (and in the interface).

@GyulyVGC
Copy link
Owner Author

Also I can't find use of color_gradients_translation in the code (and in the interface).

It will be used once the GUI library I'm using will support color gradients.
I've already put it to not have to ask again for that translation in the near future.

@amarao amarao mentioned this issue May 18, 2023
@vcrn
Copy link
Contributor

vcrn commented May 22, 2023

I've added a Swedish translation and some small corrections to other texts. Some letters can't be displayed though (which I go into detail in the PR) and there's also the question of placement of the language in the page where you select your language.

Thank you for a great tool!

@GyulyVGC
Copy link
Owner Author

I've added a Swedish translation and some small corrections to other texts. Some letters can't be displayed though (which I go into detail in the PR) and there's also the question of placement of the language in the page where you select your language.

Thank you for a great tool!

I must also be thanking you for the translation!
As answered in the PR, I'll take care of fixing those problems

@Br1ght0ne
Copy link
Contributor

Updated the Ukrainian translation :)

@GyulyVGC
Copy link
Owner Author

GyulyVGC commented Jun 1, 2023

I've merged all the submitted PRs with your language updates.
Thank you very much to all of you guys ❤️

We are now at 14 out of 16 completely updated languages.

Just for your information, these are the missing languages:

  • Greek
  • Portuguese

I've also updated the original message of this issue with a nice-to-have of the Japanese 🇯🇵 language (I feel like it's the most popular language between the app users that is still missing).

@hirotake111
Copy link
Contributor

@GyulyVGC
I'm making a change to add the Japanese language to Sniffnet. However, most of the characters are not displayed for reasons.
(I can't see Hiragana, Kanakata, and some Kanji characters. It looks like some are displayed as Sniffnet has already had a Chinese language feature?)

Do you have any idea? Or do I need to add some font files to it?

@GyulyVGC
Copy link
Owner Author

Hi @hirotake111

That's because I use a reduced font to not waste binary size.
From the full font files, I will select only the actually user characters, which will be included in the reduced font files.

You can submit the PR and I'll take care of the rest.

@GyulyVGC GyulyVGC added the translation User interface translation label Dec 24, 2023
@GyulyVGC
Copy link
Owner Author

GyulyVGC commented Apr 8, 2024

Hey all!

Sniffnet v1.3 has just been published, so it'd be amazing if you could help updating your translation.


➡️ All you have to do is to add the translations to this file:

Thank you all very much in advance for the help ❤️

@Charpy
Copy link
Contributor

Charpy commented Apr 8, 2024

Starting French translation update ! ;)

update : done

@Dinozavvvr
Copy link
Contributor

Dinozavvvr commented Apr 8, 2024

Hi there! I could help you with Russian if you don't mind) Like this comment and I will start it)

update: done
#496

@hirotake111
Copy link
Contributor

Hi @GyulyVGC,
I have just submitted a PR (Japanese translation). Feel free to contact me if you need 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed translation User interface translation
Projects
None yet
Development

No branches or pull requests