fix: use os.RemoveAll for non-empty directories when --force is set#9
Merged
Conversation
When --force is set and the existing path is a real directory (not a symlink), os.Remove fails because it cannot remove non-empty directories. This causes the force flag to silently skip the path. Use os.RemoveAll instead when the existing path is a directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--forceis set and the existing path is a real directory (not a symlink),os.Removesilently fails because it cannot remove non-empty directories, causing the force flag to have no effectos.RemoveAllwhen the existing path is a directory, in bothlinkComponentDirandlinkComponentPathsRoot Cause
~/.agents/skills/loopfixwas a real directory (installed by another tool/plugin, not a symlink). The linker usedos.Removeto clear existing paths during force-overwrite, butos.Removeonly works on files, empty directories, and symlinks.Test Plan
go test ./...)--forcewhen a skill directory already exists at the target path