Skip to content

Fix blank page rendering, clean up CSS architecture, and add click-to-rename functionality#127

Merged
hung319 merged 7 commits intomasterfrom
copilot/fix-css-error-issue-again
Jan 16, 2026
Merged

Fix blank page rendering, clean up CSS architecture, and add click-to-rename functionality#127
hung319 merged 7 commits intomasterfrom
copilot/fix-css-error-issue-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 16, 2026

The notification settings page (and other pages) rendered completely blank due to malformed HTML where the <app-redirect> custom element was placed outside the <body> tag. Additionally, inline CSS styles were duplicated across multiple files making the codebase harder to maintain.

Changes

HTML Structure Fix

  • Moved <app-redirect> inside <body> tag in src/webui/src/components/base.astro
  • Reordered head elements to ensure <ViewTransitions /> is last before </head> closes

CSS Consolidation

  • Removed all inline <style> blocks from base.astro (toggle switch styles) and navbar.astro (navigation alignment styles)
  • Removed inline style attributes from navbar elements (<nav>, <div>, <a> tags)
  • Consolidated all CSS into styles.css with proper organization:
    • Navigation display, alignment, and gap spacing
    • Navigation link white-space handling
    • Toggle switch alignment and positioning

Click-to-Rename Functionality

  • Created new InlineRename component with click-to-edit functionality
  • Removed rename option from dropdown menu - now directly accessible by clicking process name
  • Process names are directly clickable - no separate edit icon needed
  • Hover effect shows blue color to indicate name is clickable
  • Keyboard shortcuts: Enter to save, Escape to cancel
  • Proper TypeScript interfaces with safe error handling

Before

</head>
<app-redirect data-base="..."></app-redirect>
<!-- content rendered without body wrapper -->

After

</head>
<body>
  <app-redirect data-base="..."></app-redirect>
  <!-- content properly wrapped in body -->
</body>

The Astro build was generating HTML with elements between </head> and body content, violating HTML5 structure and causing browser rendering failures.

Benefits

  • ✅ Valid HTML5 structure with proper element nesting
  • ✅ Single source of truth for all CSS styles
  • ✅ Cleaner HTML without duplicate inline styles
  • ✅ Easier to maintain and update styles going forward
  • ✅ More intuitive rename UX - click directly on process name to edit
  • ✅ Cleaner UI without extra icons or buttons
  • ✅ Reduced clicks needed to rename processes

Screenshots

Before (Blank Page Issue)

After (Fixed Rendering)

Click-to-Rename Feature

Original prompt

@copilot The CSS error still exists, please see the image. Try release test
Screenshot_20260114_123214_Chrome
Screenshot_20260114_123205_Chrome


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CSS error in release test Fix blank page rendering caused by malformed HTML structure Jan 16, 2026
Copilot AI requested a review from nou183007785 January 16, 2026 00:43
@nou183007785
Copy link
Copy Markdown
Collaborator

@copilot No, the CSS for the top bar nav and the toggle switch in the notify feature hasn't been fixed yet. Please delete it and recreate it.

Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 16, 2026

@copilot No, the CSS for the top bar nav and the toggle switch in the notify feature hasn't been fixed yet. Please delete it and recreate it.

I've removed all inline CSS styles from the navbar and toggle switches, and consolidated everything into styles.css.

Changes in commit d0c47b4:

  • Deleted inline <style> blocks from base.astro and navbar.astro
  • Removed all inline style attributes from navbar elements
  • Moved all CSS to styles.css with proper nav and toggle switch styling

The page renders correctly with the same visual appearance.

Cleaned navbar rendering

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/opm/opm/src/webui/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix blank page rendering caused by malformed HTML structure Fix blank page rendering and clean up CSS architecture Jan 16, 2026
@nou183007785
Copy link
Copy Markdown
Collaborator

@copilot, please correct the rename section. I want the edit option to appear next to the original name, not in the menu.

@nou183007785
Copy link
Copy Markdown
Collaborator

@copilot, remove the pen icon from the rename function, and the rename function is currently not working.

Copilot AI and others added 3 commits January 16, 2026 02:32
Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 16, 2026

@copilot, please correct the rename section. I want the edit option to appear next to the original name, not in the menu.

I've moved the rename functionality to appear inline next to the process name with a hover-activated edit icon.

Changes in commits 6b63966, 3e1ba77, and 81cc7df:

  • Created new InlineRename component with edit icon that appears on hover
  • Removed rename option from dropdown menu
  • Edit icon now appears directly next to process name when you hover over the card
  • Click the edit icon to enable inline editing, press Enter to save or Escape to cancel

Inline rename UI

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/opm/opm/src/webui/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix blank page rendering and clean up CSS architecture Fix blank page rendering, clean up CSS architecture, and add inline rename functionality Jan 16, 2026
Co-authored-by: nou183007785 <225401975+nou183007785@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 16, 2026

@copilot, remove the pen icon from the rename function, and the rename function is currently not working.

I've removed the pen/edit icon. The process name is now directly clickable for renaming.

Changes in commit 49cf239:

  • Removed PencilIcon - no separate edit button
  • Process name itself is now clickable
  • Hover over the name shows blue color to indicate it's clickable
  • Click the name to enter edit mode
  • Enter to save, Escape to cancel

Clickable name for rename

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/opm/opm/src/webui/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix blank page rendering, clean up CSS architecture, and add inline rename functionality Fix blank page rendering, clean up CSS architecture, and add click-to-rename functionality Jan 16, 2026
@hung319 hung319 marked this pull request as ready for review January 16, 2026 02:48
@hung319 hung319 merged commit be23b80 into master Jan 16, 2026
@hung319 hung319 deleted the copilot/fix-css-error-issue-again branch February 26, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants