-
Notifications
You must be signed in to change notification settings - Fork 118
improved mp3 detection #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cant pass flake8 tests, i give up, feel free to remove comments |
|
You have the errors in the logs, just fix them and update the PR. |
Yea i saw it, E117 error was added with latest commit and idk how to fix E129 without make it looks ugly |
|
Yay, thanks @MikhailMurashov for fixing flake issues |
|
@guigarfr can we merge it? |
|
@MikhailMurashov I don't have any permissions to merge... I gues you'll need a reviewer or two approving so that can be merged? I don't know. If it was me the reviewer i would say:
@h2non can someone else review this? |
fixes #139
references:
https://www.datavoyage.com/mpgscript/mpeghdr.htm
https://en.wikipedia.org/wiki/MP3#/media/File:Mp3filestructure.svg