Skip to content

Update some default configs to reduce memory use#1127

Merged
h2zero merged 1 commit intomasterfrom
nrf-mem-use
Mar 26, 2026
Merged

Update some default configs to reduce memory use#1127
h2zero merged 1 commit intomasterfrom
nrf-mem-use

Conversation

@h2zero
Copy link
Copy Markdown
Owner

@h2zero h2zero commented Mar 26, 2026

Summary by CodeRabbit

  • New Features
    • Added default configuration options for BLE runtime sizing: transport event discardable count, periodic sync limit, and multi-advertiser instance count. These settings can be customized per device if needed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 56a96b90-1997-4e7e-a540-c535614fdd0b

📥 Commits

Reviewing files that changed from the base of the PR and between 4746c60 and 7300b1d.

📒 Files selected for processing (2)
  • src/syscfg/devcfg/nrf51cfg.h
  • src/syscfg/devcfg/nrf52810cfg.h

📝 Walkthrough

Walkthrough

Two Nordic device configuration headers (nrf51cfg.h and nrf52810cfg.h) are updated with conditional default macros for BLE runtime sizing: MYNEWT_VAL_BLE_TRANSPORT_EVT_DISCARDABLE_COUNT (8), MYNEWT_VAL_BLE_MAX_PERIODIC_SYNCS (0), and MYNEWT_VAL_BLE_MULTI_ADV_INSTANCES (0). The nrf51 config additionally reformats existing PHY feature macros.

Changes

Cohort / File(s) Summary
BLE Configuration Macro Defaults
src/syscfg/devcfg/nrf51cfg.h
Added three new conditional macro definitions (BLE_TRANSPORT_EVT_DISCARDABLE_COUNT, BLE_MAX_PERIODIC_SYNCS, BLE_MULTI_ADV_INSTANCES). Reformatted two existing PHY feature macros (LE_2M_PHY, LE_CODED_PHY) with explicit parentheses; values remain (0).
BLE Configuration Macro Defaults
src/syscfg/devcfg/nrf52810cfg.h
Added three new conditional macro definitions (BLE_TRANSPORT_EVT_DISCARDABLE_COUNT, BLE_MAX_PERIODIC_SYNCS, BLE_MULTI_ADV_INSTANCES) with defaults 8, 0, and 0 respectively, guarded by #ifndef checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

⚓ Configuration macros set sail today,
Defaults for BLE channels now in place,
Nordic devices charting steady course,
No storms ahead—just steady force! 🏴‍☠️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the pull request—adding default configuration macros to reduce memory use in Nordic device configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nrf-mem-use

Comment @coderabbitai help to get the list of available commands and usage tips.

@h2zero h2zero merged commit fa001a9 into master Mar 26, 2026
42 checks passed
@h2zero h2zero deleted the nrf-mem-use branch March 26, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant