Skip to content

[Bugfix] Use the correct taskData when retrieving descriptors#422

Merged
h2zero merged 1 commit intomasterfrom
bugfix/retrieve-descriptor-taskdata
Apr 24, 2026
Merged

[Bugfix] Use the correct taskData when retrieving descriptors#422
h2zero merged 1 commit intomasterfrom
bugfix/retrieve-descriptor-taskdata

Conversation

@h2zero
Copy link
Copy Markdown
Owner

@h2zero h2zero commented Apr 24, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@h2zero has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 52 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 52 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2104af13-8506-484a-a8d5-82e87abd253e

📥 Commits

Reviewing files that changed from the base of the PR and between 6b69cb1 and abfe6c8.

📒 Files selected for processing (1)
  • src/NimBLERemoteCharacteristic.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/retrieve-descriptor-taskdata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes descriptor discovery to consistently use the correct TaskData instance when waiting for and reading discovery results, preventing mismatched state when a custom filter is supplied.

Changes:

  • Ensures retrieveDescriptors() always wires the active stack taskData into the filter used by the discovery callback.
  • Reads completion status from the local taskData rather than indirectly through pFilter->taskData.
  • Simplifies getDescriptor() filter construction while relying on retrieveDescriptors() to bind taskData.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/NimBLERemoteCharacteristic.cpp
@h2zero h2zero force-pushed the bugfix/retrieve-descriptor-taskdata branch from 0bdbd2c to 8493b87 Compare April 24, 2026 22:01
@h2zero h2zero force-pushed the bugfix/retrieve-descriptor-taskdata branch from 8493b87 to abfe6c8 Compare April 24, 2026 22:17
@h2zero h2zero merged commit 1eddc28 into master Apr 24, 2026
66 checks passed
@h2zero h2zero deleted the bugfix/retrieve-descriptor-taskdata branch April 24, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants