Skip to content

refactor(tracing): rename tracing channel h3.fetch to h3.request#176

Merged
pi0 merged 1 commit intoh3js:mainfrom
logaretm:awad/rename-tracing-channels
Feb 5, 2026
Merged

refactor(tracing): rename tracing channel h3.fetch to h3.request#176
pi0 merged 1 commit intoh3js:mainfrom
logaretm:awad/rename-tracing-channels

Conversation

@logaretm
Copy link
Contributor

@logaretm logaretm commented Feb 5, 2026

We discussed that .request better describes what this does and more in line with other frameworks/conventions.

Summary by CodeRabbit

  • Refactor
    • Updated tracing channel naming from "srvx.fetch" to "srvx.request" for fetch event tracing to improve consistency and clarity in event categorization within the system.

@logaretm logaretm requested a review from pi0 as a code owner February 5, 2026 19:22
Copilot AI review requested due to automatic review settings February 5, 2026 19:22
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request renames the debug tracing channel identifier from "srvx.fetch" to "srvx.request" across the tracing implementation, example usage, and corresponding tests. No logic, error handling, or control flow changes are introduced.

Changes

Cohort / File(s) Summary
Implementation & Examples
src/tracing.ts, examples/tracing/server.ts
Updated the tracingChannel invocation to use "srvx.request" instead of "srvx.fetch" for fetch-related event tracing.
Tests
test/tracing.test.ts
Updated two test cases to expect the renamed "srvx.request" channel instead of "srvx.fetch".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • pi0

Poem

A rabbit hopped through channels bright,
And changed "fetch" to "request"—how right!
The logs now dance with newer names,
No logic swayed, just channel games,
A simple hop, both clean and tight! 🐰✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 5, 2026

Open in StackBlitz

npm i https://pkg.pr.new/h3js/srvx@176

commit: 933ae32

@pi0 pi0 changed the title refactor(tracing): Rename tracing channel h3.fetch to h3.request refactor(tracing): rename tracing channel h3.fetch to h3.request Feb 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the tracing channel from srvx.fetch to srvx.request to better describe the functionality and align with conventions used in other frameworks.

Changes:

  • Renamed tracing channel identifier from srvx.fetch to srvx.request throughout the codebase
  • Updated documentation comments to reflect the new channel name
  • Updated all tests and examples to use the new channel name

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/tracing.ts Updated the tracing channel name in implementation and documentation comments from srvx.fetch to srvx.request
test/tracing.test.ts Updated test cases to subscribe to the renamed srvx.request channel instead of srvx.fetch
examples/tracing/server.ts Updated example code to use the new srvx.request channel name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pi0 pi0 merged commit b425701 into h3js:main Feb 5, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants