Only throw_if in setOption if setting an option failed, fix filtergraph parsing, add sample aspect ratio accessors #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't throw if av_opt_set returned zero (success). Also fixed segfault in filtergraph parsing. We only need to manually free AVFilterInOut structures after using
avfilter_graph_parse_ptras in the example but we useavfilter_graph_parsewhich frees automatically (and if we do the same after the program segfaults). Hence all the unique_ptr machinery is not needed. Although the filter classes certainly needs some work to make them easier to use and more abstract, like, the in/out filters could be created automatically and we'd only provide the actual filters.Another feature for the filters is easy access to sample (pixel) aspect ratio in video frame and codec context. It's used in filter input initialization, and while unnecessary would be good to have it exposed for consistency.