Append transpiled es5 version#7
Merged
Merged
Conversation
Owner
|
Fantastic @alexbadm, thank you! <3 Would be happy to merge this. It was requested by someone else too in #6, so this is a valuable contribution. Could you add an ES5 example in the example directory to show how the ES5 build can be used and also to work as a test to make sure it works in the browser too? Perhaps also consider adding a note in the README at an appropriate place to describe how the user can use logplease as a ES5 module? |
Owner
|
Nvm my previous comment @alexbadm. I can merge this as is and quickly add the examples and update README myself. |
Owner
|
Thank you for the contribution @alexbadm! Will update the readme and examples and publish a new version to npm soon (1.2.14). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logplease package unable to used with create-react-app because it written in es6, but create-react-app doesn't allow to configure webpack bundler.
I added transpiled version of your package and put it in the es5 folder so that anyone can import it if needed.