Skip to content

Append transpiled es5 version#7

Merged
haadcode merged 3 commits into
haadcode:masterfrom
alexbadm:master
Aug 21, 2017
Merged

Append transpiled es5 version#7
haadcode merged 3 commits into
haadcode:masterfrom
alexbadm:master

Conversation

@alexbadm
Copy link
Copy Markdown
Contributor

@alexbadm alexbadm commented Jul 20, 2017

logplease package unable to used with create-react-app because it written in es6, but create-react-app doesn't allow to configure webpack bundler.
I added transpiled version of your package and put it in the es5 folder so that anyone can import it if needed.

@haadcode
Copy link
Copy Markdown
Owner

Fantastic @alexbadm, thank you! <3 Would be happy to merge this. It was requested by someone else too in #6, so this is a valuable contribution.

Could you add an ES5 example in the example directory to show how the ES5 build can be used and also to work as a test to make sure it works in the browser too?

Perhaps also consider adding a note in the README at an appropriate place to describe how the user can use logplease as a ES5 module?

@haadcode
Copy link
Copy Markdown
Owner

Nvm my previous comment @alexbadm. I can merge this as is and quickly add the examples and update README myself.

@haadcode haadcode merged commit a9889cf into haadcode:master Aug 21, 2017
@haadcode
Copy link
Copy Markdown
Owner

Thank you for the contribution @alexbadm! Will update the readme and examples and publish a new version to npm soon (1.2.14).

@haadcode haadcode mentioned this pull request Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants