Skip to content

Add typescript support#219

Merged
simonebortolin merged 3 commits intomainfrom
feature/typescript-support
Jun 7, 2023
Merged

Add typescript support#219
simonebortolin merged 3 commits intomainfrom
feature/typescript-support

Conversation

@nanomad
Copy link
Copy Markdown
Contributor

@nanomad nanomad commented Jun 6, 2023

No description provided.

@simonebortolin
Copy link
Copy Markdown
Contributor

simonebortolin commented Jun 7, 2023 •
edited
Loading

I do not see the point of compiling typescript but not compiling the vue code, which is used for the eeprom viewer.

I believe that a pr that adds support for TS should be done after or at the same time as supporting the compilation of the vue code, which unlike TS also works without compilation.

@nanomad nanomad temporarily deployed to internal June 7, 2023 20:18 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2023

Preview of the website obtained from the PR: https://65167a9b.hack-gpon-preview.pages.dev

@simonebortolin simonebortolin merged commit b5aa73a into main Jun 7, 2023
@simonebortolin simonebortolin deleted the feature/typescript-support branch June 7, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonebortolin simonebortolin simonebortolin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nanomad @simonebortolin