Skip to content

Split trace compare types into owned module#287

Merged
yvette-carlisle merged 1 commit into
mainfrom
xy/split-trace-compare-types
Jun 30, 2026
Merged

Split trace compare types into owned module#287
yvette-carlisle merged 1 commit into
mainfrom
xy/split-trace-compare-types

Conversation

@yvette-carlisle

Copy link
Copy Markdown
Member

Summary

  • Split trace-compare-owned DTO and SQL row types from app/types.rs into trace_compare/types.rs.
  • Kept trace_compare.rs focused on orchestration, DB fetches, and replay assembly, while analysis.rs keeps pure analysis helpers.
  • Added a focused serialization contract test for the nested trace compare report output.

Validation

  • cargo make fmt-rust
  • cargo nextest run -p elf-eval --all-targets --all-features trace_compare (7 passed)
  • cargo make lint-vstyle
  • cargo make fmt-rust-check
  • git diff --check
  • cargo make check-rust
  • cargo make lint-rust
  • cargo make test-rust (386 passed, 92 skipped)
  • cargo make check (386 passed, 92 skipped)

Review

  • Scout selected the trace-compare type cluster as a narrow owner boundary.
  • Skeptic passed with no blockers after staged-diff review.

…o owned module after strict validation.","authority":"manual"}
@yvette-carlisle yvette-carlisle merged commit eb78c50 into main Jun 30, 2026
12 checks passed
@yvette-carlisle yvette-carlisle deleted the xy/split-trace-compare-types branch June 30, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant