Skip to content

Stabilize frozen drag release cursor mapping#74

Merged
yvette-carlisle merged 2 commits intomainfrom
codex/fix-frozen-drag-release-jitter
Apr 10, 2026
Merged

Stabilize frozen drag release cursor mapping#74
yvette-carlisle merged 2 commits intomainfrom
codex/fix-frozen-drag-release-jitter

Conversation

@yvette-carlisle
Copy link
Copy Markdown
Member

Summary

  • keep rounded overlay cursor mapping for live cursor, loupe, and RGB sampling
  • scope floored coordinate mapping to active frozen selection drag updates only
  • cover the frozen drag cursor-move plus release path with a regression test

Testing

  • cargo make fmt-rust
  • cargo test -p rsnap-overlay overlay_window_event_global_position_rounds_fractional_scaled_positions --lib
  • cargo test -p rsnap-overlay frozen_selection_drag_uses_non_rounding_cursor_move_updates_without_shifting_cursor_context --lib
  • cargo test -p rsnap-overlay frozen_selection_drag_ --lib
  • cargo make test-rust

Refs XY-237

… cursor mapping","authority":"manual","breaking":false}
@yvette-carlisle
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…n drag release mapping","authority":"manual","breaking":false}
@yvette-carlisle yvette-carlisle merged commit 4b527bd into main Apr 10, 2026
7 checks passed
@yvette-carlisle yvette-carlisle deleted the codex/fix-frozen-drag-release-jitter branch April 10, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant