Skip to content

XY-246 add shared frozen annotation style controls and toolbar polish#86

Merged
yvette-carlisle merged 4 commits into
mainfrom
yvette/xy-246-add-brush-colorwidth-controls-with-shared-annotation-style
Apr 13, 2026
Merged

XY-246 add shared frozen annotation style controls and toolbar polish#86
yvette-carlisle merged 4 commits into
mainfrom
yvette/xy-246-add-brush-colorwidth-controls-with-shared-annotation-style

Conversation

@yvette-carlisle
Copy link
Copy Markdown
Member

Summary

  • add shared frozen annotation style controls for brush and text in the frozen toolbar
  • support brush color and size, text size/color adjustments, and carry the selected styles through preview and export rendering
  • polish toolbar interaction behavior, including wheel and +/- size adjustments plus macOS drag handling and layout cleanup

Testing

  • cargo make lint-rust
  • cargo make test-rust

Follow-up

  • XY-247 tracks splitting the expanded style controls into a separate capsule instead of continuing to expand the main toolbar

@yvette-carlisle
Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a88767c051

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rsnap-overlay/src/overlay.rs
@yvette-carlisle
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…style controls and toolbar polish","authority":"XY-246"}
…mports and drag handle warnings","authority":"XY-246"}
@yvette-carlisle yvette-carlisle force-pushed the yvette/xy-246-add-brush-colorwidth-controls-with-shared-annotation-style branch from e4da907 to a13867c Compare April 13, 2026 13:46
@yvette-carlisle yvette-carlisle merged commit a5e11f8 into main Apr 13, 2026
7 checks passed
@yvette-carlisle yvette-carlisle deleted the yvette/xy-246-add-brush-colorwidth-controls-with-shared-annotation-style branch April 13, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant