Skip to content

allow macOS capture windows to be externally recorded#94

Merged
yvette-carlisle merged 2 commits intomainfrom
yvette/self-capture-regression-fix
Apr 14, 2026
Merged

allow macOS capture windows to be externally recorded#94
yvette-carlisle merged 2 commits intomainfrom
yvette/self-capture-regression-fix

Conversation

@yvette-carlisle
Copy link
Copy Markdown
Member

Summary

  • disable window content protection for macOS capture-session overlay, HUD, loupe, toolbar, and scroll preview windows so system screenshot and full-screen recording can capture rsnap itself
  • add a regression test covering the shared content-protection setting
  • update the capture-session spec to match the current lazy window lifecycle and external-capture expectation

Testing

  • cargo test -p rsnap-overlay --quiet
  • cargo make lint
  • git diff --check

…o be externally recorded","authority":"manual"}
@yvette-carlisle
Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f096f675d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rsnap-overlay/src/overlay/rendering/scroll_preview_window.rs Outdated
@yvette-carlisle
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@yvette-carlisle yvette-carlisle merged commit a532f8d into main Apr 14, 2026
7 checks passed
@yvette-carlisle yvette-carlisle deleted the yvette/self-capture-regression-fix branch April 14, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant