fix: stabilize capture entry and preview-first frozen handoff#97
Conversation
…review-first frozen handoff","authority":"manual"}
|
@codex review |
…age in capture entry","authority":"manual"}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bccf84cff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…etion on refreshed stream generation","authority":"manual"}
…macos capture helpers","authority":"manual"}
|
@codex review |
…for rustfmt","authority":"manual"}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a46a2dc35e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…it tests in live capture","authority":"manual"}
|
@codex review |
…ery changes for rustfmt","authority":"manual"}
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce11e3b5db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let LiveCaptureInteraction::PressPending { monitor, .. } = self.live_capture_interaction | ||
| else { | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
When a pending click hit test times out, this branch resets LiveCaptureInteraction::PressPending to hover/idle without checking whether the mouse button has been released. If the user is still holding the button (common on cold startup when the first hit test takes >250ms), the later ElementState::Released event no longer matches PressPending/DraggingSelection, so no frozen capture starts and the click is dropped. Keep the press interaction until release (or trigger an explicit fallback capture) to avoid losing the capture action.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Refs XY-260
Refs XY-261