Modify Profile page to match new designs #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hack4impact/memberdb-tool/dC3j9iSpSwjDhnRge7CEYfB1Rxzr |
Leundai
requested changes
Jul 17, 2021
Member
Leundai
left a comment
Leundai
left a comment
There was a problem hiding this comment.
Looks great! Just one quick thing it seems like the non-editable fields are barely readable on my screen. If we can darken the font color that might be helpful.
Also, make sure that the navbar changes are compatible with the new navbar.
Comment on lines
+11
to
+13
| .profile-card .row { | ||
| /* padding-top: 30px !important; */ | ||
| } |
Member
There was a problem hiding this comment.
Remove this if it is not needed
Comment on lines
+8
to
+11
| const Profile = () => ( | ||
| <div className="profile-page"> | ||
| <Page title="Profile"> | ||
| <ProfileCard /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status:
🚀 Ready
Description
Reworking the profile page to match the new figma designs and abstracting the logic
Fixes #102
Todos
Screenshots