Rewrite rating-service.spec.ts to use TestDatabaseService#121
Merged
Conversation
Agent-Logs-Url: https://github.com/hackaburg/tilt/sessions/012258df-1c79-427f-b7cf-19ce732775bb Co-authored-by: sezanzeb <28510156+sezanzeb@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sezanzeb
April 6, 2026 23:13
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rating-service.spec.tsused hand-rolled mock repos, making tests brittle and disconnected from actual DB behavior. This rewrites it to useTestDatabaseService(in-memory SQLite) in the style ofproject-service.spec.ts.Changes
TestDatabaseService:beforeAllbootstraps the DB once;beforeEachcallsdatabase.nuke()and re-seeds real entities via TypeORM.User,Team,Project,Criterion, andRatingare persisted and resolved through actual queries — no moremockResolvedValuechains on fake repo objects.ISettingsServiceremains mocked: it has no DB backing, soMockSettingsServiceis kept.getRatingResultsaggregation.