Skip to content

Add types to StackWithBorder & TeamMember; fix all frontend typecheck errors#125

Merged
sezanzeb merged 1 commit intoteams2from
copilot/add-types-stackwithborder-teammember
Apr 12, 2026
Merged

Add types to StackWithBorder & TeamMember; fix all frontend typecheck errors#125
sezanzeb merged 1 commit intoteams2from
copilot/add-types-stackwithborder-teammember

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 12, 2026

The frontend had untyped component props and several type errors causing yarn run frontend::typecheck to fail.

Types added

  • StackWithBorder — new StackWithBorderProps interface with text?, tooltip?, and children? as optional:
    interface StackWithBorderProps {
      text?: string;
      tooltip?: string;
      children?: React.ReactNode;
    }
  • TeamMember / TeamMemberRequest — typed with TeamResponseDTO, UserListDto, and explicit callback signatures

Type errors fixed

  • TS2345 (edit-team.tsx): updateTeam was called with a spread TeamResponseDTO which is incompatible with TeamDTO (owner: UserResponseDto vs UserDTO). Changed the API method to accept TeamUpdateDTO and the call site to pass only { id, title, description, teamImg }.
  • TS2554 (api/index.ts): delete() accepts 1 argument but removeUserFromTeam was passing a spurious {} as never second arg.
  • TS6133 (edit-team.tsx): Removed unused TextField and Stack imports.
  • TS6133 (rating-form.tsx): Removed unused Tooltip import.

@sezanzeb sezanzeb marked this pull request as ready for review April 12, 2026 15:17
@sezanzeb sezanzeb merged commit c129d71 into teams2 Apr 12, 2026
@sezanzeb sezanzeb deleted the copilot/add-types-stackwithborder-teammember branch April 12, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants