Add tests for // TODO test comments; remove resolved TODOs#126
Merged
Add tests for // TODO test comments; remove resolved TODOs#126
// TODO test comments; remove resolved TODOs#126Conversation
Agent-Logs-Url: https://github.com/hackaburg/tilt/sessions/7c7127d4-6d01-41ef-a09c-77b78c39886d Co-authored-by: sezanzeb <28510156+sezanzeb@users.noreply.github.com>
Agent-Logs-Url: https://github.com/hackaburg/tilt/sessions/0ea22aa8-e99a-4fdb-9faf-330de9442742 Co-authored-by: sezanzeb <28510156+sezanzeb@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sezanzeb
April 12, 2026 21:30
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
// TODO testcomments existed inrating-service.ts,team-service.ts, andapplication-controller.tswith no corresponding coverage. This adds the missing tests and removes the now-resolved TODO comments.New tests
rating-service.spec.ts—getUsersRatingsForProjectteam-service.spec.ts— expanded coveragecreateTeam: owner is set to the creator; user'steamfield is assignedacceptUserToTeam: only owner or root admin may accept; others throwremoveUserFromTeam: users can remove themselves; removing the owner throws; success nullifiesteamsetOwner: non-owner/non-admin throws; target not in team throws; success updates ownerapplication-controller.spec.ts— new filegetAllTeams: email addresses are absent from the serialized response (simulatesResponseInterceptorwithclassToPlain+excludeAll;UserResponseDtoonly exposesid,firstName,lastName)Cleanup
All 11
// TODO testcomments across the three source files have been removed.