Skip to content

fix(img): restore icon256.png lost during webp migration (73d6ed0)#545

Merged
hackademix merged 3 commits intohackademix:mainfrom
KhaledSaeed18:fix/restore-icon256-png
Apr 14, 2026
Merged

fix(img): restore icon256.png lost during webp migration (73d6ed0)#545
hackademix merged 3 commits intohackademix:mainfrom
KhaledSaeed18:fix/restore-icon256-png

Conversation

@KhaledSaeed18
Copy link
Copy Markdown
Contributor

fix: restore src/img/icon256.png to resolve broken README logo

Summary

Restores src/img/icon256.png, which was lost during the icon format migration and not recovered in the subsequent cross-browser icon support commit, causing the README logo to render as a broken image.

Root Cause

Commit Description Effect on icon256
e3e9b82 Convert PNG images to WEBP icon256.png replaced by icon256.webp
73d6ed0 Cross-browser icon support (SVG on Gecko, PNG on Chromium) icon256.webp removed, icon256.png not re-added

The README has referenced src/img/icon256.png throughout both commits. After 73d6ed0 landed, no file exists at that path.

Changes

  • src/img/icon256.png — restored from commit c053486 (last commit prior to the WEBP migration)

Verification

README logo renders correctly with this file in place. No other references to icon256 in the codebase are affected.

Screenshot 2026-04-14 at 6 20 04 AM

Closes #544

@hackademix
Copy link
Copy Markdown
Owner

hackademix commented Apr 14, 2026

Thank you very much for your contribution.
Rather than re-adding the png file, though, I'd prefer src/img/logo-full.svg (already there) to be used in README.md.
Can you amend this patch? Otherwise I'll do it myself.

Thanks!

@KhaledSaeed18
Copy link
Copy Markdown
Contributor Author

Hello @hackademix
Done, removed src/img/icon256.png, switched to src/img/logo-full.svg, and added an alt attribute.

@hackademix
Copy link
Copy Markdown
Owner

lgtm!

Merging, thank you!

@hackademix hackademix merged commit 5075721 into hackademix:main Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README logo broken

2 participants