Guard OpenAI tool registration when bridging#106
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
codex-extended/codex-rs/core/src/openai_tools.rs
Lines 115 to 117 in 6b2986e
[P0] Dereference missing in streamable shell guard
The new ToolsConfig::new condition that switches to ShellWithRequest now uses !use_streamable_shell_tool, but use_streamable_shell_tool is a &bool because params is destructured from &ToolsConfigParams. Applying ! to a reference does not compile (Not is not implemented for &bool). The previous code dereferenced the value, and the other branches still use *use_streamable_shell_tool. As written, codex-core will fail to build once compilation reaches this module. Change the condition to !*use_streamable_shell_tool (or bind a value instead of a reference) so the code compiles.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
Testing
just fix -p codex-core(fails: codex-ollama does not compile because serde_json::Error::custom is unavailable and ResponseEvent lacks Clone)cargo test -p codex-core(fails: codex-ollama does not compile because serde_json::Error::custom is unavailable and ResponseEvent lacks Clone)https://chatgpt.com/codex/tasks/task_b_68c85e82d89c832f93d409b768aa4ded