Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the task representation by replacing the boolean :done field with a more explicit :state field that uses keyword values (:open, :checked). This change improves code clarity by making task states more explicit and maintainable.
Key changes:
- Replaced boolean
:donefield with keyword-based:statefield supporting:openand:checkedstates - Updated task builder functions to use the new state system
- Modified parser and serializer logic to handle state keywords instead of boolean values
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/task.janet | Updated task builder functions to use :state field with keyword values instead of :done boolean |
| src/plan/parser.janet | Modified parser to generate :state with :checked/:open keywords from checkbox syntax |
| src/plan/serializer.janet | Updated serializer to convert :state keywords back to checkbox syntax |
| src/plan.janet | Refactored completed-tasks and pending-tasks filters to check :state equality |
| test/task_test.janet | Added comprehensive tests for new task builder functions and updated existing tests |
| test/schedule_parser_test.janet | Updated test assertions to check :state field |
| test/plan/serializer_test.janet | Updated test data to use :state keywords |
| test/plan/parser_test.janet | Updated test assertions to verify :state values |
| test/examples/todo.md | Changed task checkboxes from checked to unchecked |
| test/commands/schedule_tasks_test.janet | Updated test assertions to check :state field |
| test/commands/schedule_contacts_test.janet | Updated test assertions to check :state field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.