feat: migrate hackclub.com DNS from DNSimple to Cloudflare #2009
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,9 +11,10 @@ jobs: | |
| with: | ||
| python-version: '3' | ||
| - name: Install OctoDNS | ||
| run: pip install 'octodns>=1.5.0' octodns-cloudflare octodns-dnsimple | ||
|
There was a problem hiding this comment. This isn't specifying the latest octoDNS version, why? The latest is 1.13.0. Additionally this doesn't use dependency pinning (recommended by octodns) meaning there could be breaking changes in an upgrade later causing the workflow to fail. |
||
| - name: Do a dry run | ||
| run: ./bin/dry-run | ||
| env: | ||
| DNSIMPLE_ACCOUNT_NUMBER: ${{ secrets.DNSIMPLE_ACCOUNT_NUMBER }} | ||
| DNSIMPLE_API_KEY: ${{ secrets.DNSIMPLE_API_KEY }} | ||
| CLOUDFLARE_TOKEN: ${{ secrets.CLOUDFLARE_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -187,7 +187,8 @@ dast: # by https://github.com/danielsebesta | |
| value: 194.163.149.155 | ||
|
There was a problem hiding this comment. This whole file should not have been changed. |
||
|
|
||
| dev-email: | ||
| - ttl: 600 | ||
| type: MX | ||
| values: | ||
| - exchange: mx1.improvmx.com. | ||
| preference: 10 | ||
|
|
@@ -289,13 +290,16 @@ heramb: | |
| value: cname.vercel-dns.com. | ||
|
|
||
| hi: # doruk.dino.icu email address | ||
| - ttl: 600 | ||
| type: TXT | ||
| value: apple-domain=rkbobCmChEtkhbTS. | ||
| hk: | ||
| - ttl: 600 | ||
| type: CNAME | ||
| value: vic.hackclub.app. | ||
| hkgi: | ||
| - ttl: 600 | ||
| type: CNAME | ||
| value: garden.devcara.com. | ||
|
|
||
| icons: # yoda - https://github.com/yodalightsabr/icons-dino-icu - a CDN for @hackclub/icons | ||
|
|
@@ -444,27 +448,6 @@ overflow: | |
| type: CNAME | ||
| value: overflow.craigg.hackclub.app. | ||
|
|
||
|
There was a problem hiding this comment. broken, was breaking build, no longer used per ella's message on slack: https://hackclub.slack.com/archives/C026RKHLPNJ/p1686773786994209 |
||
|
|
||
| pay: # by Ella | ||
| ttl: 600 | ||
|
|
@@ -586,27 +569,7 @@ spend: | |
| type: A | ||
| value: 76.76.21.21 | ||
|
|
||
|
There was a problem hiding this comment. broken, was breaking build, no longer used per ella's message on slack: https://hackclub.slack.com/archives/C026RKHLPNJ/p1686773786994209 |
||
|
|
||
|
|
||
| social: | ||
| ttl: 600 | ||
|
|
@@ -670,7 +633,7 @@ vansh: | |
|
|
||
| vercel: | ||
| - ttl: 600 | ||
| type: CNAME | ||
| value: cname.vercel-dns.com. | ||
|
|
||
| vercel-a: | ||
|
|
@@ -680,7 +643,7 @@ vercel-a: | |
|
|
||
| vercel-alias: | ||
| ttl: 600 | ||
| type: CNAME | ||
| value: cname.vercel-dns.com. | ||
|
|
||
| vercel-cname: | ||
|
|
@@ -742,20 +705,8 @@ www: # redirect to bare domain | |
| type: CNAME | ||
| value: cname.vercel-dns.com. | ||
|
|
||
|
Comment on lines
-745
to
-757
There was a problem hiding this comment. Also, why were these subdomains of dino.icu deleted? There was a problem hiding this comment. none of these seem used anymore, new versions of octodns no longer support emoji in dns There was a problem hiding this comment. was breaking build on new version of octodns |
||
| yc: | ||
| ttl: 600 | ||
| type: NS | ||
| value: ns.youngchief.xyz. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't specifying the latest octoDNS version, why? The latest is 1.13.0. Additionally this doesn't use dependency pinning (recommended by octodns) meaning there could be breaking changes in an upgrade later causing the workflow to fail.