Skip to content

fixed label spacing between view resume and upload resume #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitGarudadri merged 6 commits into from
Dec 23, 2019
Merged

fixed label spacing between view resume and upload resume #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3132c7
fixed label spacing between view resume and upload resume
RohitGarudadri Dec 21, 2019
7f5ea65
Merge branch 'develop' into feature/205-resume-button-spacing
RohitGarudadri Dec 22, 2019
f96a771
Fixed button spacing and placed view resume on right side
RohitGarudadri Dec 22, 2019
31f85dc
Label spacing fixed
RohitGarudadri Dec 22, 2019
7c028e4
Merge branch 'develop' into feature/205-resume-button-spacing
RohitGarudadri Dec 23, 2019
fd368c4
fix changelog
RohitGarudadri Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Button spacing on application page
- Label spacing between view resume and upload resume while editing application
- Checkmark not aligning with checkbox on smaller screens
- Checkmark appearing on dropdown lists due to z-index
- Job interest dropdown colours
Expand Down
6 changes: 4 additions & 2 deletions src/features/Application/ResumeComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ const ResumeComponent: React.StatelessComponent<IResumeProps & FieldProps> = (
return (
<Flex mb={'20px'}>
<Box>{props.mode === ManageApplicationModes.EDIT && viewResume}</Box>
<Box>
<Box ml={props.mode === ManageApplicationModes.EDIT ? '10px' : ''}>
<Label>
<LabelText label={props.label} required={props.required} />
<FileUpload {...props} />
<div style={{ marginLeft: '-10px' }}>
<FileUpload {...props} />
</div>
</Label>
</Box>
</Flex>
Expand Down
4 changes: 3 additions & 1 deletion src/shared/Elements/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ export const Button = styled.button<IButtonProps>`
font-size: 16px;
font-weight: 400;
text-transform: capitalize;
height: 40px;
min-height: 40px;
max-height: 60px;


/* Default border radius to values befiting a call to action button
- these values will be reset later if button is not a call to action */
Expand Down