Skip to content

Fixed checkmark alignment with checkbox on smaller screens #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitGarudadri merged 4 commits into from
Dec 23, 2019
Merged

Fixed checkmark alignment with checkbox on smaller screens #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bffdd4
Fixed checkmark alignment with chekcbox on smaller screens
RohitGarudadri Dec 22, 2019
412fdfa
Fixed checkmark alignment with chekcbox on smaller screens
RohitGarudadri Dec 22, 2019
60296cc
Merge branch 'develop' into feature/192-centered-checkbox
RohitGarudadri Dec 22, 2019
8be0a3b
Merge branch 'develop' into feature/192-centered-checkbox
RohitGarudadri Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Button spacing on application page
- Checkmark not aligning with checkbox on smaller screens
- Checkmark appearing on dropdown lists due to z-index
- Job interest dropdown colours

Expand Down
14 changes: 8 additions & 6 deletions src/shared/Form/FormikElements/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ const CheckboxContainer = styled.div`
transform: rotate(45deg);
position: relative;
left: 25px;
top: 3px;
z-index: 1;
top: 6px;
display: inline-block;
cursor: pointer;
}
Expand Down Expand Up @@ -86,11 +86,13 @@ const FormikCheckbox: React.StatelessComponent<ICheckboxProps & FieldProps> = ({
>
<LabelText label={labelElement} required={required} />
<CheckboxContainer>
<span className="checkmark">
<div className="checkmark_stem" />
<div className="checkmark_kick" />
</span>
<Checkbox {...field} checked={field.value} />
<Flex>
<span className="checkmark">
<div className="checkmark_stem" />
<div className="checkmark_kick" />
</span>
<Checkbox {...field} checked={field.value} />
</Flex>
</CheckboxContainer>
</Flex>
</Label>
Expand Down