Create Default Account Role, Add rolebinding on creation#157
Merged
pierreTklein merged 4 commits intodevelopfrom Dec 1, 2018
Merged
Create Default Account Role, Add rolebinding on creation#157pierreTklein merged 4 commits intodevelopfrom
pierreTklein merged 4 commits intodevelopfrom
Conversation
YiFeiZhang2
reviewed
Nov 23, 2018
Member
YiFeiZhang2
left a comment
YiFeiZhang2
left a comment
There was a problem hiding this comment.
Should we consider removing the accountRole routes from the other Roles such as volunteer, hacker, etc, so we do not get this duplication of route access?
Member
Author
|
Yeah I was thinking about that. It doesn't break any logic-- do you think that it's worth removing, or do we just keep it? |
Member
|
I think it's worth removing. |
Member
Author
|
Following this line of thought, |
Member
|
That's a fair point. |
YiFeiZhang2
approved these changes
Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152