Skip to content

Feature/184 degree type#185

Merged
pierreTklein merged 1 commit intodevelopfrom
feature/184-degree_type
Dec 3, 2018
Merged

Feature/184 degree type#185
pierreTklein merged 1 commit intodevelopfrom
feature/184-degree_type

Conversation

@krubenok
Copy link
Copy Markdown
Member

@krubenok krubenok commented Dec 3, 2018

Description

Add degree type as a field to the hacker schema and the associated tests

Fixes #184

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • local instance testing with postman

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pierreTklein pierreTklein changed the base branch from master to develop December 3, 2018 02:02
Copy link
Copy Markdown
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierreTklein pierreTklein merged commit c7c3f38 into develop Dec 3, 2018
@pierreTklein pierreTklein deleted the feature/184-degree_type branch December 20, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Degree Type to Hacker Model

2 participants