Skip to content

Make ObjectIds constant#189

Merged
pierreTklein merged 4 commits intodevelopfrom
bug/188
Dec 3, 2018
Merged

Make ObjectIds constant#189
pierreTklein merged 4 commits intodevelopfrom
bug/188

Conversation

@YiFeiZhang2
Copy link
Copy Markdown
Member

Description

Use createFromTime with a constant integer to make constant ObjectIds

Fixes #188

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Passes local unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

Copy link
Copy Markdown
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what about the singular roles?

@YiFeiZhang2
Copy link
Copy Markdown
Member Author

Forgot about those haha. Updated

pierreTklein
pierreTklein previously approved these changes Dec 3, 2018
@pierreTklein pierreTklein merged commit b95ebf8 into develop Dec 3, 2018
@YiFeiZhang2 YiFeiZhang2 deleted the bug/188 branch December 16, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ObjectId for Roles to be based on a seed

2 participants