Skip to content

Conversation

@YiFeiZhang2
Copy link
Member

@YiFeiZhang2 YiFeiZhang2 commented Dec 15, 2018

Description

Add an optional field in boolean validator, which if entered, will check that the field equals the value.
This allows for confirmation that a field is a boolean, and a specific value, which is now being used in codeOfConduct validation in hacker.

Issue #204

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a new test for a hacker that does not accept the code of conduct.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@YiFeiZhang2 YiFeiZhang2 merged commit d150a79 into master Dec 15, 2018
@YiFeiZhang2 YiFeiZhang2 deleted the bug/204 branch December 16, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants