Skip to content

Conversation

@pierreTklein
Copy link
Member

@pierreTklein pierreTklein commented Dec 17, 2018

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #215

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test authentication
  • Test authorization
  • Test return object

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@krubenok
Copy link
Member

krubenok commented Dec 17, 2018

@pierreTklein can you elaborate on what this returns and what fields are included in these stats?

I'm thinking it might be interesting to be able to flag collecting stats on all applicants vs. all confirmed hackers.

@pierreTklein
Copy link
Member Author

pierreTklein commented Dec 17, 2018

@krubenok
Example return:

"stats": {
    "total": 2,
    "status": {
        "Applied": 2
    },
    "school": {
        "McGill University": 2
    },
    "degree": {
        "Undergraduate": 1,
        "Masters": 1
    },
    "gender": {
        "Male": 2
    },
    "needsBus": {
        "false": 2
    },
    "ethnicity": {
        "White or Caucasian": 2
    },
    "jobInterest": {
        "Internship": 2
    },
    "major": {
        "Computer Science": 1,
        "Accounting": 1
    },
    "graduationYear": {
        "2019": 2
    },
    "dietaryRestrictions": {
        "Halal": 1,
        "Gluten-Free": 1
    },
    "shirtSize": {
        "S": 2
    },
    "age": {
        "21": 2
    }
}

@loreina
Copy link
Member

loreina commented Dec 17, 2018

I think in the meantime, we just need to know info on all hackers and we can build a better spec for this for another PR?

@pierreTklein pierreTklein changed the base branch from master to develop December 17, 2018 03:41
@krubenok
Copy link
Member

krubenok commented Dec 17, 2018

Yeah no reason not to approve just didn't see this before the PR lol. This is super useful!

@pierreTklein
Copy link
Member Author

Yeah, that would definitely be helpful. I can look into appending this onto the /search route so that you can filter before aggregating. @pashakondratyev , what do you think?

@loreina loreina self-requested a review December 17, 2018 03:50
Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this 👏

@krubenok
Copy link
Member

Yeah, if we can run stats on a search query that would be insanely cool and more flexible too!

@pierreTklein pierreTklein merged commit 4e7bebb into develop Dec 17, 2018
@pierreTklein pierreTklein deleted the feature/215-getStats branch December 20, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Stats

4 participants