Skip to content

Conversation

@YiFeiZhang2
Copy link
Member

Description

The test database entries have confusing variable names, leading to a bad database. For example, a volunteer had two role bindings.

Fixes #287

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Passes current unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works, thanks for in the time! We should sit down one day and fully flesh out either documentation or another refactor which allows for on-the-fly database population.

@YiFeiZhang2 YiFeiZhang2 merged commit 3489ff3 into develop Jan 16, 2019
@loreina loreina deleted the feature/287 branch November 21, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor account utils

3 participants