release: v3.0.0

[loreina]

List of changes:

• feat!: fix non-determinism of npm run seed (feat: fix non-determinism of npm run seed (Bugfix/651) #652)
• feat: add batchAccept route to accept multiple hackers at once (feat: add batchAccept route to accept multiple hackers at once #629)

Type of change

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• New release
• This change requires a documentation update

Steps from here:

• 1. Use mongodump locally as backup

- [ ] 2. Add npm run seed to script run in Heroku deployment in Procfile

this means on push to master, npm run seed will be part of CI and automatically run

^ saving this for later, after the API refactor

looks like Heroku recommends processes in Procfile to only run 1 command, see: https://help.heroku.com/CTFS2TJK/how-do-i-run-multiple-processes-on-a-dyno

• 3. Manually run npm run seed on production db

• 4. Manually update all rolebindings in production db

Run this for each rolebinding, switching the new one in to the old one

db.rolebindings.updateMany(
    { "roles": <new> }, 
    { "$set": { "roles.$": <old> } }
)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Listed change(s) in the Changelog
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules

[logan-r]

Looks good! We can automatically generate the update statements to reconcile role _ids using something like

/**
 * Create an object that defines the mapping between role `_id`s pre and post `npm run seed`
 * @param {Array} previousRoleCollection JSON export of roles collection, pre `npm run seed`
 * @param {Array} newRoleCollection JSON export of roles collection, post `npm run seed`
 */
function createRoleMigrationMapping(previousRoleCollection, newRoleCollection) {
    // `_id` mapping, keyed by role name
    let roleMigrationMapping = {}
    
    // Iterate through each role, and find their individual `_id` mapping
    for (let prevRole of previousRoleCollection) {
        roleMigrationMapping[prevRole.name] = { 
            formerId: prevRole._id.$oid,
            newId: newRoleCollection.find(newRole => newRole.name === prevRole.name)._id.$oid
        }
    }

    return roleMigrationMapping
}

// Create migration mapping - put JSON exports of roles collection here
let roleIdMapping = createRoleMigrationMapping(previousRoleCollection, newRoleCollection)

// For each role generate an updateMany statement to reconcile rolebindings
for (let role in roleIdMapping) {
    console.log(`
        db.rolebindings.updateMany(
            { "roles": ObjectId("${roleIdMapping[role].formerId}") }, 
            { "$set": { "roles.$": ObjectId("${roleIdMapping[role].newId}") } }
        )
    `)
}

[pierreTklein]

Can you confirm that role names are unique?

Edit: Just checked: yes they are unique