Skip to content

release: v3.0.0 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2020
Merged

release: v3.0.0 #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ae3ce2
feat: fix non-determinism of npm run seed (Bugfix/651) (#652)
pierreTklein Jul 26, 2020
28e074f
feat: add batchAccept route to accept multiple hackers at once (#629)
ManethKulatunge Jul 27, 2020
ec1c284
release: bump to v3.0.0
loreina Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions constants/role.constant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,27 +151,26 @@ function createAllSingularRoles() {
const allRoutes = Constants.Routes.allRoutes;
let roles = [];

// i is unique integer so that objectId is constant
var i = 1000000;
for (let routeGroupKey in allRoutes) {
if (!allRoutes.hasOwnProperty(routeGroupKey)) {
if (!Object.prototype.hasOwnProperty.call(allRoutes, routeGroupKey)) {
continue;
}

const routeGroup = allRoutes[routeGroupKey];
for (let routeKey in routeGroup) {
if (!routeGroup.hasOwnProperty(routeKey)) {
// Iterating through the attributes in the routeGroup object
if (!Object.prototype.hasOwnProperty.call(routeGroup, routeKey)) {
// Avoid all prototype attributes
continue;
}

let role = {
_id: mongoose.Types.ObjectId(i),
_id: routeGroup[routeKey]._id,
name: routeKey + routeGroupKey,
routes: routeGroup[routeKey]
};
let roleName = role.name;
roles[roleName] = role;
i -= 1;
}
}

Expand All @@ -197,7 +196,7 @@ function createAllRoles() {

const singularRoles = createAllSingularRoles();
for (let role in singularRoles) {
if (!singularRoles.hasOwnProperty(role)) {
if (!Object.prototype.hasOwnProperty.call(singularRoles, role)) {
continue;
}
allRolesObject[role] = singularRoles[role];
Expand Down
Loading