Skip to content

fix： share github secrets to dependabot #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2021
Merged

fix： share github secrets to dependabot #712

merged 1 commit into from
Jul 10, 2021

Conversation

@chenxuan-zhou
Copy link
Contributor

@chenxuan-zhou chenxuan-zhou commented Jul 10, 2021

Tickets:

List of changes:

  • fixed the problem of Dependabot not having access to GitHub Secrets

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Not tested. Need to merge to dev and rerun the Dependabot actions.

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@chenxuan-zhou chenxuan-zhou requested a review from jamesxu123 July 10, 2021 15:01
jamesxu123
jamesxu123 approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@jamesxu123 jamesxu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a test!

@jamesxu123 jamesxu123 merged commit 26f05d4 into dev Jul 10, 2021
@jamesxu123 jamesxu123 deleted the feature/hac-35-dependabot-prs-cant-see-repo-secrets branch July 10, 2021 15:03
chenxuan-zhou added a commit that referenced this pull request Jul 10, 2021
@chenxuan-zhou
fix： share github secrets to dependabot (#712) (#713)
14042ec
chenxuan-zhou added a commit that referenced this pull request Jul 10, 2021
@chenxuan-zhou
fix： share github secrets to dependabot (#712) (#714)
819bbfe
jamesxu123 pushed a commit that referenced this pull request Jul 11, 2021
@dependabot @chenxuan-zhou
build(deps): bump debug from 4.1.1 to 4.3.2 (#711)
bfbba7f 
* build(deps): bump debug from 4.1.1 to 4.3.2

Bumps [debug](https://github.com/visionmedia/debug) from 4.1.1 to 4.3.2.
- [Release notes](https://github.com/visionmedia/debug/releases)
- [Commits](debug-js/debug@4.1.1...4.3.2)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix： share github secrets to dependabot (#712) (#713)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tracy <46543122+chenxuan-zhou@users.noreply.github.com>
jamesxu123 pushed a commit that referenced this pull request Jul 11, 2021
@dependabot @chenxuan-zhou
build(deps-dev): bump eslint from 6.7.2 to 7.30.0 (#710)
939ed5c 
* build(deps-dev): bump eslint from 6.7.2 to 7.30.0

Bumps [eslint](https://github.com/eslint/eslint) from 6.7.2 to 7.30.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v6.7.2...v7.30.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix： share github secrets to dependabot (#712) (#714)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tracy <46543122+chenxuan-zhou@users.noreply.github.com>
@jamesxu123 jamesxu123 linked an issue Jul 11, 2021 that may be closed by this pull request
Dependabot PRs can't see Repo Secrets #709
Closed
pengyk added a commit that referenced this pull request Nov 25, 2021
@pengyk
Revert "fix： share github secrets to dependabot (#712)"
e764f6d 
This reverts commit 26f05d4.
pengyk added a commit that referenced this pull request Nov 25, 2021
@pengyk
Revert "fix： share github secrets to dependabot (#712)" (#771)
c762a5c 
This reverts commit 26f05d4.
logan-r pushed a commit that referenced this pull request Nov 29, 2021
@chenxuan-zhou @logan-r
fix： share github secrets to dependabot (#712)
c86991a
logan-r pushed a commit that referenced this pull request Nov 29, 2021
@dependabot @chenxuan-zhou @logan-r
build(deps): bump debug from 4.1.1 to 4.3.2 (#711)
a850990 
* build(deps): bump debug from 4.1.1 to 4.3.2

Bumps [debug](https://github.com/visionmedia/debug) from 4.1.1 to 4.3.2.
- [Release notes](https://github.com/visionmedia/debug/releases)
- [Commits](debug-js/debug@4.1.1...4.3.2)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix： share github secrets to dependabot (#712) (#713)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tracy <46543122+chenxuan-zhou@users.noreply.github.com>
logan-r pushed a commit that referenced this pull request Nov 29, 2021
@dependabot @chenxuan-zhou @logan-r
build(deps-dev): bump eslint from 6.7.2 to 7.30.0 (#710)
857e6e8 
* build(deps-dev): bump eslint from 6.7.2 to 7.30.0

Bumps [eslint](https://github.com/eslint/eslint) from 6.7.2 to 7.30.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v6.7.2...v7.30.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix： share github secrets to dependabot (#712) (#714)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tracy <46543122+chenxuan-zhou@users.noreply.github.com>
logan-r pushed a commit that referenced this pull request Nov 29, 2021
@pengyk @logan-r
Revert "fix： share github secrets to dependabot (#712)" (#771)
e19193e 
This reverts commit 26f05d4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesxu123 jamesxu123 jamesxu123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dependabot PRs can't see Repo Secrets

3 participants

@chenxuan-zhou @jamesxu123