Skip to content

Conversation

@JamieXiao
Copy link
Contributor

Tickets:

  • HAC-

List of changes:

  • Fixed cutoff to 2025-11-17T23:59:59.000Z
  • Assign only to applications without reviewer statuses (ie. reviewer status = none)

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Changes in hacker.middleware.js

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@tektaxi tektaxi merged commit 800bf3a into dev Nov 21, 2025
1 check failed
@tektaxi tektaxi deleted the feat/more-reviewers branch November 21, 2025 07:02
tektaxi pushed a commit that referenced this pull request Nov 21, 2025
* quick fixes to assignreviewers

* fixed non existant fields conditional statements for assignReviewers

* need to fix: reviewer1 & 2 have same name

* fixed duplicate names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants