Skip to content

quick fixes to assignReviewers #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2025
Merged

quick fixes to assignReviewers #961

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3422081
quick fixes to assignreviewers
JamieXiao Nov 21, 2025
08725c8
fixed non existant fields conditional statements for assignReviewers
JamieXiao Nov 21, 2025
07cd2bd
need to fix: reviewer1 & 2 have same name
JamieXiao Nov 21, 2025
7b767ca
fixed duplicate names
JamieXiao Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions middlewares/hacker.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,15 +758,21 @@ async function assignReviewers(req, res, next) {
const REVIEWER_NAMES = req.body.names;
console.log('Reviewer names:', REVIEWER_NAMES);

const cutoff = new Date('2025-11-27T17:23:59.000Z'); // EDIT: set your desired cutoff date here
const cutoff = new Date('2025-11-17T23:59:59.000Z'); // EDIT: set your desired cutoff date here
const cutoffObjectId = new ObjectId(Math.floor(cutoff.getTime() / 1000).toString(16) + "0000000000000000");

const hackerModel = require('../models/hacker.model');

// find all hackers created before the cutoff date
const hackers = await hackerModel.find({
$or: [
{ reviewerStatus: 'None' },
{ reviewerStatus2: 'None' },
{ reviewerStatus: { $exists: false } },
{ reviewerStatus2: { $exists: false } }
],
_id: { $lte: cutoffObjectId }
}).select('_id');
}).select('_id reviewerStatus reviewerStatus2 accountId reviewerName reviewerName2');

console.log('Found hackers:', hackers.length);

Expand Down Expand Up @@ -795,14 +801,37 @@ async function assignReviewers(req, res, next) {

// assign reviewers to hackers
for (const hacker of hackers) {
const assignedReviewer1 = REVIEWER_NAMES[hackerIndex % revwiewerCount];
const assignedReviewer2 = REVIEWER_NAMES[(hackerIndex + 1) % revwiewerCount];

assignments.push({ hackerId: hacker._id, reviewer: assignedReviewer1, reviewer2: assignedReviewer2 });
let assignedReviewer1 = REVIEWER_NAMES[hackerIndex % revwiewerCount];
let assignedReviewer2 = REVIEWER_NAMES[(hackerIndex + 1) % revwiewerCount];

updatePromises.push(
Services.Hacker.updateOne(hacker._id, { reviewerName: assignedReviewer1, reviewerName2: assignedReviewer2 })
);
if (hacker.reviewerStatus !== HACKER_REVIEWER_STATUS_NONE && ("reviewerStatus" in hacker)) {
if (hacker.reviewerName === assignedReviewer2) {
assignedReviewer2 = assignedReviewer1;
}

assignments.push({ hackerId: hacker._id, reviewer2: assignedReviewer2 });

updatePromises.push(
Services.Hacker.updateOne(hacker._id, { reviewerName2: assignedReviewer2 })
);
} else if (hacker.reviewerStatus2 !== HACKER_REVIEWER_STATUS_NONE && ("reviewerStatus2" in hacker)) {

if (hacker.reviewerName2 === assignedReviewer1) {
assignedReviewer1 = assignedReviewer2;
}

assignments.push({ hackerId: hacker._id, reviewer: assignedReviewer1 });

updatePromises.push(
Services.Hacker.updateOne(hacker._id, { reviewerName: assignedReviewer1 })
);
} else {
assignments.push({ hackerId: hacker._id, reviewer: assignedReviewer1, reviewer2: assignedReviewer2 });

updatePromises.push(
Services.Hacker.updateOne(hacker._id, { reviewerName: assignedReviewer1, reviewerName2: assignedReviewer2 })
);
}

hackerIndex++;
}
Expand Down
Loading