Export Gitlab Snippets 400 error visibility does not have a valid value

[mouson]

When I export snippet to GitLab (11.3.1) send a request to my private GitLab host

ENV:
Codimd 1.2.1
GitLab 11.3.1
CMD_GITLAB_VERSION=v4

request:

snippets?access_token=xxxxxxxxxx

title: test snippet
file_name: test_snippet.md
code: some content
===
some things
visibility_level: 0
visibility: 

---

Response

{"error":"visibility does not have a valid value"}

[mouson]

visibility needs

visibility	Description
private	The snippet is visible only the snippet creator
internal	The snippet is visible for any logged in user
public	The snippet can be accessed without any authentication

ref: Project snippets | GitLab

[SISheogorath]

Interested in providing a patch? Would be nice to see a contribution :)

codimd/lib/response.js

Lines 580 to 609 in c03b42d

	function gitlabActionProjects (req, res, note) {
	if (req.isAuthenticated()) {
	models.User.findOne({
	where: {
	id: req.user.id
	}
	}).then(function (user) {
	if (!user) { return response.errorNotFound(res) }
	var ret = { baseURL: config.gitlab.baseURL, version: config.gitlab.version }
	ret.accesstoken = user.accessToken
	ret.profileid = user.profileid
	request(
	config.gitlab.baseURL + '/api/' + config.gitlab.version + '/projects?access_token=' + user.accessToken,
	function (error, httpResponse, body) {
	if (!error && httpResponse.statusCode === 200) {
	ret.projects = JSON.parse(body)
	return res.send(ret)
	} else {
	return res.send(ret)
	}
	}
	)
	}).catch(function (err) {
	logger.error('gitlab action projects failed: ' + err)
	return response.errorInternalError(res)
	})
	} else {
	return response.errorForbidden(res)
	}
	}

Sounds like a good issue to get started ^^

[micedre]

Sorry, it's probably my fault, I do not have time to verify but I believe changing the line in

codimd/public/js/index.js

Line 1482 in 466dc9b

visibility: $('#snippetExportModalVisibility').val() === 0 ? 'private' : ($('#snippetExportModalVisibility').val() === 10 ? 'internal' : '')

to

   visibility: $('#snippetExportModalVisibility').val() === '0' ? 'private' : ($('#snippetExportModalVisibility').val() === '10' ? 'internal' : 'public')

should work.